Skip to content

Conversation

@asmacdo
Copy link
Member

@asmacdo asmacdo commented Oct 14, 2021

Related to #5115

This PR introduces the Dockerfile and infrastructure to build Ansible
2.9 and Ansible 2.11 images side by side.

This commit does not integrate
these changes into CI, and therefore will need to be mered alongside a
follow-up PR to intetgrate with GitHub actions.

@asmacdo
Copy link
Member Author

asmacdo commented Oct 14, 2021

/hold

This PR should not be merged until this work is included in CI.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2021
@asmacdo asmacdo added this to the v1.14.0 milestone Oct 14, 2021
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2021
@asmacdo asmacdo force-pushed the ansible-2.11-builds branch from 233081b to a32fb30 Compare November 3, 2021 15:07
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2021
fabianvf and others added 2 commits November 3, 2021 11:09
Related to operator-framework#5115

This PR introduces the Dockerfile and infrastructure to build Ansible
2.9 and Ansible 2.11 images side by side. This commit does not integrate
these changes into CI, and therefore will need to be mered alongside a
follow-up PR to intetgrate with GitHub actions.

Co-authored-by: Austin Macdonald <[email protected]>
Co-authored-by: Fabian von Feilitzsch <[email protected]>

Signed-off-by: austin <[email protected]>
@asmacdo asmacdo force-pushed the ansible-2.11-builds branch from a32fb30 to 333d30b Compare November 3, 2021 15:10
@asmacdo
Copy link
Member Author

asmacdo commented Nov 4, 2021

Unclear why the go e2e test failed (timed out on operator-sdk olm uninstall). https://github.com/operator-framework/operator-sdk/runs/4099782969?check_suite_focus=true#step:5:618
Failed twice in a row, ill kick it off once more tonight, and again in the morning hoping that this is a flake caused by an external issue. Test passed, it was just a flake.

@asmacdo asmacdo modified the milestones: v1.14.0, v1.15.0 Nov 4, 2021
Signed-off-by: austin <[email protected]>
@asmacdo asmacdo removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2021
@asmacdo
Copy link
Member Author

asmacdo commented Nov 5, 2021

This is ready for review. In particular, extra eyes on deploy-manual.yaml since that step is not tested in PRs.

Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants