Bump k8s dependencies to 1.21+#5057
Merged
varshaprasad96 merged 7 commits intoJul 15, 2021
Merged
Conversation
Signed-off-by: varshaprasad96 <varshaprasad96@gmail.com>
varshaprasad96
force-pushed
the
bump/k8s-1.21
branch
from
c33d6fe to
cb08356
Compare
Signed-off-by: varshaprasad96 <varshaprasad96@gmail.com>
varshaprasad96
commented
Jul 13, 2021
| Namespace: "default", | ||
| }, | ||
| }, | ||
| ExpectedObject: &unstructured.Unstructured{ |
Member
Author
There was a problem hiding this comment.
This change is because of kubernetes-sigs/controller-runtime#1399. When the finalizer is successfully run and is removed, the fake client updates the object and immediately sends it for deletion.
| )) | ||
|
|
||
| // verify workqueue | ||
| Expect(q.Len()).To(Equal(2)) |
Member
Author
There was a problem hiding this comment.
this is because of the deduplication of events before being sent into work queue.
ref: kubernetes-sigs/controller-runtime#1390
varshaprasad96
force-pushed
the
bump/k8s-1.21
branch
2 times, most recently
from
f2208a3 to
2ee0204
Compare
Signed-off-by: varshaprasad96 <varshaprasad96@gmail.com>
varshaprasad96
force-pushed
the
bump/k8s-1.21
branch
from
2ee0204 to
5dd1d91
Compare
Signed-off-by: varshaprasad96 <varshaprasad96@gmail.com>
varshaprasad96
force-pushed
the
bump/k8s-1.21
branch
from
815aeef to
4b83e06
Compare
varshaprasad96
force-pushed
the
bump/k8s-1.21
branch
from
63a24e9 to
0ebec26
Compare
varshaprasad96
commented
Jul 14, 2021
| export SIMPLE_VERSION = $(shell (test "$(shell git describe)" = "$(shell git describe --abbrev=0)" && echo $(shell git describe)) || echo $(shell git describe --abbrev=0)+git) | ||
| export GIT_VERSION = $(shell git describe --dirty --tags --always) | ||
| export GIT_COMMIT = $(shell git rev-parse HEAD) | ||
| # TODO: bump this to 1.21, after kubectl `--generator` flag is removed from e2e tests. |
Member
Author
There was a problem hiding this comment.
leaving this for now, since --generator flag is deprecated here and the test needs to be re-written, in sdk and kubebuilder. Will do this in a follow up PR, as I didn't want to block updating of k8s in projects because of this.
|
|
||
| if urlPath != nil && urlPath.Path != "" { | ||
| log.Error(fmt.Errorf("api endpoint '%s' contains a path component, which the proxy server is currently unable to handle properly. Work on this issue is being tracked here: https://github.com/operator-framework/operator-sdk/issues/4925", cfg.Host), "") | ||
| if err := verifyCfgURL(cfg.Host); err != nil { |
Member
Author
There was a problem hiding this comment.
refactoring to reduce cyclomatic complexity and make linter happy.
Signed-off-by: varshaprasad96 <varshaprasad96@gmail.com>
varshaprasad96
force-pushed
the
bump/k8s-1.21
branch
from
0ebec26 to
8bf53fb
Compare
estroz
reviewed
Jul 14, 2021
estroz
reviewed
Jul 14, 2021
varshaprasad96
force-pushed
the
bump/k8s-1.21
branch
from
409b2ba to
39f2358
Compare
Signed-off-by: varshaprasad96 <varshaprasad96@gmail.com>
varshaprasad96
force-pushed
the
bump/k8s-1.21
branch
from
39f2358 to
9d86eb1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Bump k8s dependencies to 1.21+
Motivation for the change:
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs