internal/plugins: follow-up updates from #4581 #4707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Stroczynski <[email protected]>
estroz
force-pushed
the
chore/fixup-after-4581
branch
from
1918223
to
4cb07d9
Compare
|
New changes are detected. LGTM label has been removed. |
Adirio
reviewed
Mar 30, 2021
Comment on lines
-42
to
-44
| defaultHelmChart = "" | ||
| defaultHelmChartRepo = "" | ||
| defaultHelmChartVersion = "" |
There was a problem hiding this comment.
These default values for flags were extracted to consts so that they could be changed easily, as they are found in two different files (in create api subcommand flag binding and in init subcommand check for non-default values when a create api call needs to be run afterwards).
There was a problem hiding this comment.
These defaults will never be anything but an empty string, so I removed them to reduce code complexity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Motivation for the change: following up on comments in #4581
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs