Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed arch with uname for finding the architecture in macOS #4705

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

dastergon
Copy link
Contributor

Description of the change:
Updated the arch command with uname for more accurate architecture identification.

Motivation for the change:
The arch command in macOS due to legacy reasons reports whether the Intel arches are capable of 32-bit.

For example, in my MBP 16" (Intel):

$ arch
i386
$ uname -m
x86_64

Consequently, the snippet for downloading operator-sdk manually. That's why I chose uname -m as a replacement.

Checklist
If the pull request includes user-facing changes, extra documentation is required:

PTAL

Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2021
@estroz estroz merged commit 33e4242 into operator-framework:master Mar 29, 2021
@dastergon dastergon deleted the chng-arch-macos branch March 29, 2021 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants