Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions changelog/fragments/reorder-docker-args.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
# entries is a list of entries to include in
# release notes and/or the migration guide
entries:
- description: >
(ansible/v1, helm/v1) Post-fixed positional directory argument `.` in `docker-build` make target to align with `podman`
kind: "change"
breaking: false

# Migration can be defined to automatically add a section to
# the migration guide. This is required for breaking changes.
migration:
header: Move positional directory argument `.` in `docker-build` make target
body: >
The directory argument `.` in the `docker-build` make target was moved to the
last positional argument to align with `podman`'s expectations, making substitution
cleaner. In your `Makefile`, change:

docker build . -t ${IMG}

to
docker build -t ${IMG} .

Alternatively, you could replace it programmatically

```sh
sed -i 's/docker build . -t ${IMG}/docker build -t ${IMG} ./' $(git grep -l 'docker.*build \. ')
```

Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ undeploy: kustomize

# Build the docker image
docker-build:
docker build . -t ${IMG}
docker build -t ${IMG} .

# Push the docker image
docker-push:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ undeploy: kustomize

# Build the docker image
docker-build:
docker build . -t ${IMG}
docker build -t ${IMG} .

# Push the docker image
docker-push:
Expand Down
2 changes: 1 addition & 1 deletion testdata/ansible/memcached-operator/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ undeploy: kustomize

# Build the docker image
docker-build:
docker build . -t ${IMG}
docker build -t ${IMG} .

# Push the docker image
docker-push:
Expand Down
2 changes: 1 addition & 1 deletion testdata/helm/memcached-operator/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ undeploy: kustomize

# Build the docker image
docker-build:
docker build . -t ${IMG}
docker build -t ${IMG} .

# Push the docker image
docker-push:
Expand Down