Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: go samples after v3 additional #4286

Merged
merged 1 commit into from
Dec 7, 2020
Merged

fix: go samples after v3 additional #4286

merged 1 commit into from
Dec 7, 2020

Conversation

camilamacedo86
Copy link
Contributor

Description

The go/v2 has not been generated in the right place after #4282 see:

Screen Shot 2020-12-07 at 10 10 08

This PR fixes that. See:

Screen Shot 2020-12-07 at 10 22 42

Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the PR and I see it now generates in testdata/go/v2/memcached-operator

@camilamacedo86 camilamacedo86 merged commit e4efaa6 into operator-framework:master Dec 7, 2020
@camilamacedo86 camilamacedo86 deleted the fix-follow-up-v3 branch December 7, 2020 15:32
estroz pushed a commit to estroz/operator-sdk that referenced this pull request Dec 7, 2020
reinvantveer pushed a commit to reinvantveer/operator-sdk that referenced this pull request Feb 5, 2021
rearl-scwx pushed a commit to rearl-scwx/operator-sdk that referenced this pull request Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants