internal/plugins: scaffold a vanilla go.kubebuilder.io/v2 project when --project-version=2
#3697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fig fields for project version 3+
openshift-ci-robot
added
do-not-merge/hold
estroz
changed the title
go.kubebuilder.io/v2 project when --project-version=2go.kubebuilder.io/v2 project when --project-version=2
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
Related to kubernetes-sigs/kubebuilder#1628 |
|
Closes #3674. |
estroz
force-pushed
the
bugfix/phase-2-scaffolds-project-version-2
branch
from
768e776
to
d2623b1
Compare
|
/cc @shawn-hurley |
This was referenced Aug 8, 2020
estroz
added a commit
to estroz/operator-sdk
that referenced
this pull request
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change: only run phase 2 plugins for project versions >= 3-alpha.
Motivation for the change: The SDK should be scaffolding the vanilla
go.kubebuilder.io/v2plugin if--project-version 2is set, since thego.sdk.operatorframework.iophase 2 plugin requires a 3-alpha project.Holding for discussion
/hold
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs