Skip to content

Conversation

@estroz
Copy link
Member

@estroz estroz commented Nov 27, 2019

Description of the change: doc/proposals/improve-csv-cli.md: 'gen-csv --inputs' proposal

Motivation for the change: see #2249 (comment).

@estroz estroz added olm-integration Issue relates to the OLM integration kind/design Categorizes issue or PR as related to design. labels Nov 27, 2019
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 27, 2019
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 great
It is /lgtm /approve for me
adding @dmesser as well here

@camilamacedo86 camilamacedo86 added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2019
Copy link
Contributor

@jmccormick2001 jmccormick2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to make sense.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2019
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jmrodri jmrodri merged commit 711c843 into operator-framework:master Jan 10, 2020
@aliok
Copy link
Contributor

aliok commented Jan 22, 2020

hi @estroz @camilamacedo86
is there way to track the implementation for this proposal?
In general, I would be happy to test drive things. Not sure if I can make any code contribs though :)

@estroz estroz deleted the doc-proposals-remove-csvconfig branch January 22, 2020 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/design Categorizes issue or PR as related to design. lgtm Indicates that a PR is ready to be merged. olm-integration Issue relates to the OLM integration size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants