(c-r v0.2.0) *: bump controller-runtime to v0.2.0, update APIs#1839
Merged
estroz merged 15 commits intooperator-framework:refactor/controller-runtime-v0.2.0from Sep 3, 2019
Merged
Conversation
estroz
requested review from
fabianvf,
jmrodri,
joelanford,
shawn-hurley and
theishshah
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
size/L
estroz
force-pushed
the
c-r-v0.2.0-rc-0
branch
from
0e3d3a9 to
d1f2408
Compare
estroz
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
joelanford
reviewed
Aug 21, 2019
Member
|
@estroz Should we go ahead and bump directly to 0.2.0 now that it's released? |
estroz
force-pushed
the
c-r-v0.2.0-rc-0
branch
from
4959d45 to
34703bf
Compare
estroz
changed the title
joelanford
approved these changes
Aug 27, 2019
Member
joelanford
left a comment
joelanford
left a comment
There was a problem hiding this comment.
LGTM after addressing last few nits
estroz
force-pushed
the
c-r-v0.2.0-rc-0
branch
from
5e69581 to
3c06471
Compare
estroz
force-pushed
the
c-r-v0.2.0-rc-0
branch
from
3c06471 to
d9bc749
Compare
secat
reviewed
Aug 27, 2019
hasbro17
reviewed
Aug 29, 2019
Co-Authored-By: Haseeb Tariq <hasbro17@gmail.com>
hasbro17
suggested changes
Sep 3, 2019
Contributor
hasbro17
left a comment
hasbro17
left a comment
There was a problem hiding this comment.
Looks good overall. Just some nits and corrections in the client documentation.
Co-Authored-By: Haseeb Tariq <hasbro17@gmail.com>
estroz
force-pushed
the
c-r-v0.2.0-rc-0
branch
from
c2637d8 to
789cb05
Compare
…ample to doc/user/client.md
estroz
force-pushed
the
c-r-v0.2.0-rc-0
branch
from
789cb05 to
11386f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Motivation for the change: controller-runtime merged an API options redux in v0.2.0-beta.5, then released v0.2.0. This PR modifies SDK code that uses affected APIs.
Migrated Ansible and Helm projects use controller-runtime directly in their
cmd/manager/main.gofiles, so controller-runtime should be pinned in their go.mod/Gopkg.toml scaffolds.