Skip to content

Conversation

@awgreene
Copy link
Member

OpenShift v4.12 had previously enforced PSA restrictions by defaults in and namespace prefixed with openshift-. This change has been delayed until OpenShift v4.13 and users should be allowed to run catalogs without restricted permissions in the openshift-marketplace namespace.

@awgreene awgreene requested a review from anik120 November 30, 2022 20:54
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2022
@bparees bparees removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2022
@bparees
Copy link

bparees commented Nov 30, 2022

lgtm

labels:
openshift.io/cluster-monitoring: "true"
pod-security.kubernetes.io/enforce: restricted
pod-security.kubernetes.io/enforce: privileged
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we checked to see if this could be baseline instead of privileged and still support legacy catalog sources?

Suggested change
pod-security.kubernetes.io/enforce: privileged
pod-security.kubernetes.io/enforce: baseline

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, let's add the following?

pod-security.kubernetes.io/audit: restricted
pod-security.kubernetes.io/warn: restricted

@awgreene
Copy link
Member Author

awgreene commented Dec 1, 2022

/retest

@anik120
Copy link
Member

anik120 commented Dec 1, 2022

+1 to all of Joe's comments otherwise lgtm

@awgreene
Copy link
Member Author

awgreene commented Dec 1, 2022

/retest

@awgreene awgreene force-pushed the unenforce-psa-restrictions branch from 329c91a to e196523 Compare December 1, 2022 14:37
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2022
@awgreene
Copy link
Member Author

awgreene commented Dec 1, 2022

/retest

13 similar comments
@awgreene
Copy link
Member Author

awgreene commented Dec 1, 2022

/retest

@awgreene
Copy link
Member Author

awgreene commented Dec 2, 2022

/retest

@awgreene
Copy link
Member Author

awgreene commented Dec 2, 2022

/retest

@awgreene
Copy link
Member Author

awgreene commented Dec 2, 2022

/retest

@awgreene
Copy link
Member Author

awgreene commented Dec 2, 2022

/retest

@awgreene
Copy link
Member Author

awgreene commented Dec 2, 2022

/retest

@awgreene
Copy link
Member Author

awgreene commented Dec 3, 2022

/retest

@awgreene
Copy link
Member Author

awgreene commented Dec 5, 2022

/retest

@awgreene
Copy link
Member Author

awgreene commented Dec 5, 2022

/retest

@awgreene
Copy link
Member Author

awgreene commented Dec 5, 2022

/retest

@awgreene
Copy link
Member Author

awgreene commented Dec 5, 2022

/retest

@awgreene
Copy link
Member Author

awgreene commented Dec 6, 2022

/retest

@awgreene
Copy link
Member Author

awgreene commented Dec 6, 2022

/retest

@awgreene
Copy link
Member Author

awgreene commented Dec 6, 2022

/test ci/prow/e2e-gcp-serial

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 6, 2022

@awgreene: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-gcp
  • /test e2e-gcp-console-olm
  • /test e2e-gcp-operator
  • /test e2e-gcp-serial
  • /test e2e-gcp-upgrade
  • /test images
  • /test okd-images
  • /test okd-scos-images
  • /test unit

The following commands are available to trigger optional jobs:

  • /test okd-e2e-gcp
  • /test okd-scos-e2e-gcp

Use /test all to run all jobs.

Details

In response to this:

/test ci/prow/e2e-gcp-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@awgreene
Copy link
Member Author

/retest

@awgreene awgreene changed the title Unenforce PSA Restrictions OCPBUGS-3881: Unenforce PSA Restrictions Dec 10, 2022
@openshift-ci-robot
Copy link
Contributor

@awgreene: This pull request references Jira Issue OCPBUGS-3881, which is invalid:

  • expected the bug to target the "4.13.0" version, but it targets "4.12.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

OpenShift v4.12 had previously enforced PSA restrictions by defaults in and namespace prefixed with openshift-. This change has been delayed until OpenShift v4.13 and users should be allowed to run catalogs without restricted permissions in the openshift-marketplace namespace.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Dec 10, 2022
@awgreene
Copy link
Member Author

/retest

2 similar comments
@awgreene
Copy link
Member Author

/retest

@awgreene
Copy link
Member Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 12, 2022

@awgreene: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-gcp 0535e66 link false /test okd-scos-e2e-gcp

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@awgreene
Copy link
Member Author

/test e2e-gcp-serial

@awgreene awgreene changed the title OCPBUGS-3881: Unenforce PSA Restrictions OCPBUGS-4758: Unenforce PSA Restrictions Dec 12, 2022
@openshift-ci-robot
Copy link
Contributor

@awgreene: This pull request references Jira Issue OCPBUGS-4758, which is invalid:

  • expected the bug to target the "4.13.0" version, but it targets "4.13" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

OpenShift v4.12 had previously enforced PSA restrictions by defaults in and namespace prefixed with openshift-. This change has been delayed until OpenShift v4.13 and users should be allowed to run catalogs without restricted permissions in the openshift-marketplace namespace.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@awgreene
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@awgreene: This pull request references Jira Issue OCPBUGS-4758, which is invalid:

  • expected the bug to target the "4.13.0" version, but it targets "4.13.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@awgreene
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 12, 2022
@openshift-ci-robot
Copy link
Contributor

@awgreene: This pull request references Jira Issue OCPBUGS-4758, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from jianzhangbjz December 12, 2022 20:01
@awgreene
Copy link
Member Author

/override e2e-gcp-serial

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 12, 2022

@awgreene: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • e2e-gcp-serial

Only the following failed contexts/checkruns were expected:

  • ci/prow/e2e-gcp
  • ci/prow/e2e-gcp-console-olm
  • ci/prow/e2e-gcp-operator
  • ci/prow/e2e-gcp-serial
  • ci/prow/e2e-gcp-upgrade
  • ci/prow/images
  • ci/prow/okd-e2e-gcp
  • ci/prow/okd-images
  • ci/prow/okd-scos-e2e-gcp
  • ci/prow/okd-scos-images
  • ci/prow/unit
  • pull-ci-operator-framework-operator-marketplace-master-e2e-gcp
  • pull-ci-operator-framework-operator-marketplace-master-e2e-gcp-console-olm
  • pull-ci-operator-framework-operator-marketplace-master-e2e-gcp-operator
  • pull-ci-operator-framework-operator-marketplace-master-e2e-gcp-serial
  • pull-ci-operator-framework-operator-marketplace-master-e2e-gcp-upgrade
  • pull-ci-operator-framework-operator-marketplace-master-images
  • pull-ci-operator-framework-operator-marketplace-master-okd-e2e-gcp
  • pull-ci-operator-framework-operator-marketplace-master-okd-images
  • pull-ci-operator-framework-operator-marketplace-master-okd-scos-e2e-gcp
  • pull-ci-operator-framework-operator-marketplace-master-okd-scos-images
  • pull-ci-operator-framework-operator-marketplace-master-unit
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override e2e-gcp-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@awgreene
Copy link
Member Author

The e2e-gcp-serial tests failed due to a slight disruption of services, which has been seen in:

  • Other PRs
  • Doc change only PRs

/override ci/prow/e2e-gcp-serial

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 12, 2022

@awgreene: Overrode contexts on behalf of awgreene: ci/prow/e2e-gcp-serial

Details

In response to this:

The e2e-gcp-serial tests failed due to a slight disruption of services, which has been seen in:

  • Other PRs
  • Doc change only PRs

/override ci/prow/e2e-gcp-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 679868a into operator-framework:master Dec 12, 2022
@openshift-ci-robot
Copy link
Contributor

@awgreene: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-4758 has been moved to the MODIFIED state.

Details

In response to this:

OpenShift v4.12 had previously enforced PSA restrictions by defaults in and namespace prefixed with openshift-. This change has been delayed until OpenShift v4.13 and users should be allowed to run catalogs without restricted permissions in the openshift-marketplace namespace.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@awgreene
Copy link
Member Author

/cherry-pick release-4.12

@openshift-cherrypick-robot

@awgreene: new pull request created: #494

Details

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants