Skip to content

[CA] Use Certificate Authority bundle #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Aug 19, 2019
Merged

[CA] Use Certificate Authority bundle #242

openshift-merge-robot merged 1 commit into from
Aug 19, 2019

Conversation

@awgreene
Copy link
Member

@awgreene awgreene commented Aug 15, 2019

This commit creates a controller that watches for events on the "marketplace-trusted-ca" ConfigMap. In the event that the ConfigMap is updated, the marketplace operator will restart, reconciling existing operands and recreate their deployments with the correct CA certificates.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 15, 2019
@awgreene awgreene force-pushed the certificate-authority branch from 4c9f244 to 600af9b Compare August 15, 2019 14:20
@awgreene
Copy link
Member Author

awgreene commented Aug 15, 2019

Waiting on openshift/cluster-network-operator#271 before this can merge.

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 15, 2019
gallettilance
gallettilance reviewed Aug 15, 2019
View reviewed changes
Copy link
Member

@gallettilance gallettilance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Do we need to add an e2e for this?

@awgreene
Copy link
Member Author

awgreene commented Aug 15, 2019

Great work! Do we need to add an e2e for this?

@galletti94 Well if the proxy is configured to use a proxy the e2e tests should fail as all requests that don't go through the proxy should fail. If the proxy is not configured, the requests shouldn't go through a (non-existant) proxy.

@awgreene
Copy link
Member Author

awgreene commented Aug 16, 2019

/retest

awgreene
awgreene commented Aug 16, 2019
View reviewed changes
@awgreene awgreene force-pushed the certificate-authority branch from 600af9b to 4816aa0 Compare August 16, 2019 17:30
danehans
danehans reviewed Aug 16, 2019
View reviewed changes
danehans
danehans reviewed Aug 16, 2019
View reviewed changes
danehans
danehans reviewed Aug 16, 2019
View reviewed changes
@awgreene awgreene force-pushed the certificate-authority branch from 4816aa0 to c37d8e3 Compare August 18, 2019 13:18
@danehans
Copy link

danehans commented Aug 18, 2019

/test e2e-aws-upgrade

@awgreene awgreene force-pushed the certificate-authority branch from c37d8e3 to d2dac4d Compare August 19, 2019 00:37
@danehans
Copy link

danehans commented Aug 19, 2019

/retest

1 similar comment
@awgreene
Copy link
Member Author

awgreene commented Aug 19, 2019

/retest

@awgreene awgreene force-pushed the certificate-authority branch from d2dac4d to 3e3f505 Compare August 19, 2019 12:32
@awgreene
Copy link
Member Author

awgreene commented Aug 19, 2019

/retest

@awgreene awgreene force-pushed the certificate-authority branch 3 times, most recently from bebacaa to 8b4cda5 Compare August 19, 2019 13:25
@awgreene
[CA] Use Certificate Authority bundle
e71ce1e 
This commit creates a controller that watches for events on the
"marketplace-operator" ConfigMap. In the event that the ConfigMap is
updated, the marketplace operator will restart, reconciling existing
operands and recreate their deployments with the correct CA
certificates.
@awgreene awgreene force-pushed the certificate-authority branch from 8b4cda5 to e71ce1e Compare August 19, 2019 13:36
@awgreene
Copy link
Member Author

awgreene commented Aug 19, 2019

/retest

1 similar comment
@awgreene
Copy link
Member Author

awgreene commented Aug 19, 2019

/retest

@awgreene
Copy link
Member Author

awgreene commented Aug 19, 2019

/test e2e-aws

@awgreene
Copy link
Member Author

awgreene commented Aug 19, 2019

/retest

@danehans
Copy link

danehans commented Aug 19, 2019

/lgtm

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 19, 2019

@danehans: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ecordell
ecordell approved these changes Aug 19, 2019
View reviewed changes
Copy link
Member

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 19, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2019
@awgreene
Copy link
Member Author

awgreene commented Aug 19, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2019
@openshift-merge-robot openshift-merge-robot merged commit 1f00d01 into operator-framework:master Aug 19, 2019
@awgreene awgreene mentioned this pull request Aug 21, 2019
Merged
@eparis
Copy link
Contributor

eparis commented Aug 21, 2019

This was reverted because of https://bugzilla.redhat.com/show_bug.cgi?id=1743699
we will need to redo this work, likely while making the configmap optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ecordell ecordell ecordell approved these changes

@aravindhp aravindhp Awaiting requested review from aravindhp

@kevinrizza kevinrizza Awaiting requested review from kevinrizza

+2 more reviewers

@danehans danehans danehans left review comments

@gallettilance gallettilance gallettilance left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@ecordell ecordell

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@awgreene @danehans @openshift-ci-robot @eparis @ecordell @gallettilance @openshift-merge-robot