Skip to content

pkg/controller: Migrate to using a read lock instead of a readwrite lock when checking for any namespace caching errors#2382

Merged
openshift-merge-robot merged 1 commit intooperator-framework:masterfrom
timflannagan:test
Sep 30, 2021
Merged

pkg/controller: Migrate to using a read lock instead of a readwrite lock when checking for any namespace caching errors#2382
openshift-merge-robot merged 1 commit intooperator-framework:masterfrom
timflannagan:test

Conversation

@timflannagan
Copy link
Copy Markdown
Member

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive

Signed-off-by: timflannagan <timflannagan@gmail.com>
@timflannagan timflannagan changed the title pkg/controller: Test commit pkg/controller: Migrate to using a read lock instead of a readwrite lock when checking for any namespace caching errors Sep 30, 2021
@exdx
Copy link
Copy Markdown
Contributor

exdx commented Sep 30, 2021

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2021
Copy link
Copy Markdown
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Sep 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2021
@openshift-merge-robot openshift-merge-robot merged commit 396b546 into operator-framework:master Sep 30, 2021
@timflannagan timflannagan deleted the test branch September 30, 2021 21:17
@timflannagan timflannagan mentioned this pull request Oct 6, 2021
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants