Skip to content

Use of/gini instead of inifrance/gini#2331

Merged
openshift-merge-robot merged 1 commit intooperator-framework:masterfrom
kevinrizza:forked-gini
Aug 18, 2021
Merged

Use of/gini instead of inifrance/gini#2331
openshift-merge-robot merged 1 commit intooperator-framework:masterfrom
kevinrizza:forked-gini

Conversation

@kevinrizza
Copy link
Copy Markdown
Member

The github.com/irifrance/gini package has been purged from github. An existing version that preserved that history has been forked to the operator-framework org, and this commit updates that dependency to use the forked version.

In the future, we should investigate https://github.com/go-air/gini if and when it creates consumable releases, as it appears that the maintainer of the missing package is now maintaining the package there.

Resolves #2322

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Aug 18, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevinrizza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2021
@timflannagan
Copy link
Copy Markdown
Member

Interesting:

--- FAIL: TestSyncOperatorGroups (1.45s)
    --- FAIL: TestSyncOperatorGroups/AllNamespaces/CSVPresent/InstallModeNotSupported (0.16s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x11577b9]

@timflannagan
Copy link
Copy Markdown
Member

It looks like there's some ordering that go mod tidy is complaining about that's failing the verification check. Likely just need to re-run that command and re-commit.

The github.com/irifrance/gini package has been purged from github
An existing version that preserved that history has been forked to the
operator-framework org, and this commit updates that dependency to use
the forked version.

Signed-off-by: kevinrizza <krizza@redhat.com>
@kevinrizza
Copy link
Copy Markdown
Member Author

@timflannagan should be fixed now

@timflannagan
Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2021
@openshift-merge-robot openshift-merge-robot merged commit 51fe6da into operator-framework:master Aug 18, 2021
anik120 pushed a commit to anik120/operator-lifecycle-manager that referenced this pull request Aug 20, 2021
The github.com/irifrance/gini package has been purged from github
An existing version that preserved that history has been forked to the
operator-framework org, and this commit updates that dependency to use
the forked version.

Signed-off-by: kevinrizza <krizza@redhat.com>
jarrpa added a commit to jarrpa/odf-operator that referenced this pull request Dec 13, 2021
This is a roundabout workaround for this issue in OLM:
operator-framework/operator-lifecycle-manager#2322

The issue was technically fixed with the v0.19.1 release with the
following PRs:
operator-framework/operator-lifecycle-manager#2331
operator-framework/operator-lifecycle-manager#2336

...however, trying to update the dependency on OLM in ocs-operator leads
to the following issue:
red-hat-storage/ocs-operator#1426

The addition of a default GOPROXY lets us access a cached version of
this package that no longer exists.

Go is wonderful, folks.

Signed-off-by: Jose A. Rivera <jarrpa@redhat.com>
jarrpa added a commit to jarrpa/odf-operator that referenced this pull request Dec 13, 2021
This is a roundabout workaround for this issue in OLM:
operator-framework/operator-lifecycle-manager#2322

The issue was technically fixed with the v0.19.1 release with the
following PRs:
operator-framework/operator-lifecycle-manager#2331
operator-framework/operator-lifecycle-manager#2336

...however, trying to update the dependency on OLM in ocs-operator
leads to the following issue:
red-hat-storage/ocs-operator#1426

The addition of a default GOPROXY lets us access a cached version of
this package that no longer exists.

Go is wonderful, folks.

Signed-off-by: Jose A. Rivera <jarrpa@redhat.com>
jarrpa added a commit to jarrpa/odf-operator that referenced this pull request Jun 17, 2022
This is a roundabout workaround for this issue in OLM:
operator-framework/operator-lifecycle-manager#2322

The issue was technically fixed with the v0.19.1 release with the
following PRs:
operator-framework/operator-lifecycle-manager#2331
operator-framework/operator-lifecycle-manager#2336

...however, trying to update the dependency on OLM in ocs-operator
leads to the following issue:
red-hat-storage/ocs-operator#1426

The addition of a default GOPROXY lets us access a cached version of
this package that no longer exists.

Go is wonderful, folks.

Signed-off-by: Jose A. Rivera <jarrpa@redhat.com>
jarrpa added a commit to jarrpa/odf-operator that referenced this pull request Jul 13, 2022
This is a roundabout workaround for this issue in OLM:
operator-framework/operator-lifecycle-manager#2322

The issue was technically fixed with the v0.19.1 release with the
following PRs:
operator-framework/operator-lifecycle-manager#2331
operator-framework/operator-lifecycle-manager#2336

...however, trying to update the dependency on OLM in ocs-operator
leads to the following issue:
red-hat-storage/ocs-operator#1426

The addition of a default GOPROXY lets us access a cached version of
this package that no longer exists.

Go is wonderful, folks.

Signed-off-by: Jose A. Rivera <jarrpa@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

irifrance/gini moved to go-air/gini

3 participants