fix(openshift): handle unquoted short max versions#2270
Merged
openshift-merge-robot merged 1 commit intoJul 20, 2021
Merged
Conversation
openshift-ci
Bot
added
the
approved
njhale
force-pushed
the
fix/block-openshift-upgrades
branch
2 times, most recently
from
10ed254 to
4b2f0f7
Compare
Add special handling for version shorthand commonly used in pipelines for Red Hat operator catalogs. Allows unquoted short versions to be used when specifying an operator's compatibility with versions of OpenShift; e.g. "olm.maxOpenShiftVersion": 4.8. Without this, OLM will only recognize quoted maxOpenShiftVersion properties; e.g. "olm.maxOpenShiftVersion": "4.8". Signed-off-by: Nick Hale <njohnhale@gmail.com>
njhale
force-pushed
the
fix/block-openshift-upgrades
branch
from
4b2f0f7 to
1ebebdb
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu, njhale The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
njhale
pushed a commit
to njhale/operator-lifecycle-manager
that referenced
this pull request
Jul 20, 2021
…shift-upgrades fix(openshift): handle unquoted short max versions Signed-off-by: Nick Hale <njohnhale@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add special handling for version shorthand commonly used in pipelines for Red Hat operator catalogs.
Allows unquoted short versions to be used when specifying an operator's OpenShift compatibility; e.g. olm.maxOpenShiftVersion: 4.8. Without this, OLM will only recognize quoted, fully qualified, maxOpenShiftVersion properties; e.g. olm.maxOpenShiftVersion: "4.8.0".
Motivation
Under my direction, Red Hat catalog pipeline maintainers have already notified bundle authors of, built automation around, and updated catalog content using this shorthand. Given this, supporting the shorthand will save these clients the effort and confusion required to switch to a fully qualified version.