add current profile annotations to CVO manifests #1832

guillaumerose · 2020-10-26T08:26:52Z

This is matches openshift/enhancements#510 and doesn't change existing behavior

Description of the change:

Motivation for the change:

Reviewer Checklist

Implementation matches the proposed design, or proposal is updated to match implementation
Sufficient unit test coverage
Sufficient end-to-end test coverage
Docs updated or added to /docs
Commit messages sensible and descriptive

openshift-ci-robot · 2020-10-26T08:27:01Z

Hi @guillaumerose. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ecordell · 2020-10-30T13:22:40Z

this looks good, but the manifests are generated from /deploy, so the manifests will need to change there in order to merge.

guillaumerose · 2020-11-02T13:19:57Z

Thanks for the advice @ecordell !

I hope what I did is not too far from what you think. I tried to keep the annotation as close as possible from ocp and not leak it in upstream.

This script adds the annotations at the end of the generation. The main issue we that is we need to deserialize/serialize the YAML. It changes the indentation, etc. With yq v3, comments are preserved but indents changed in some places.

Let me know what you think!

kevinrizza · 2020-11-30T16:04:06Z

/ok-to-test
/lgtm
/approve

openshift-ci-robot · 2020-11-30T16:04:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guillaumerose, kevinrizza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [kevinrizza]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-11-30T16:28:58Z

/retest