Add Admission Webhook Document #17
Conversation
anik120
left a comment
anik120
left a comment
There was a problem hiding this comment.
@awgreene Thank you for your PR. I've left some comments on organisation of the doc. Specifically, the way the hugo doc site is laid out, we want to organize things a little differently than our docs in our github repo. After you open your PR, you can check the netlify/operator-lifecycle-manager/deploy-preview target that CI provides for you, to get a preview of what the doc site will look like with your current changes.
Looks like since this doc does not have the header that hugo expects, it's not showing up in the doc site as of now.
Also, it feels like Adding Admission Webhook should be under the Advanced task section.
We organised the Core task section to include a logical sequence of tasks you can perform with OLM:
- Install OLM
- Make your operator part of a Catalog
- Create a Catsrc with the Catalog
- Create a subscription to your operator
.
.
etc.
Seems like adding admission webhook does not go in the flow of core tasks for now. Please correct me if I'm wrong.
awgreene
force-pushed
the
admission-webhooks-doc
branch
9 times, most recently
from
ef40030 to
9dec818
Compare
|
@anik120 I think we're good to go, can you review? |
anik120
left a comment
anik120
left a comment
There was a problem hiding this comment.
@awgreene Thank you for making the changes. Looks like we have the doc in the right place and it renders in the website correctly. I've made a few suggestions around the language in the doc, just so that the language in the doc is consistent with the other docs.
Otherwise /approve
anik120
added
the
approved
awgreene
force-pushed
the
admission-webhooks-doc
branch
from
9dec818 to
60901a7
Compare
|
Great edits @anik120 |
awgreene
force-pushed
the
admission-webhooks-doc
branch
2 times, most recently
from
23de1b4 to
d274e7c
Compare
njhale
left a comment
njhale
left a comment
There was a problem hiding this comment.
This looks awesome! I have a few last comments that I'd like to get your thoughts on before we merge.
awgreene
force-pushed
the
admission-webhooks-doc
branch
from
d274e7c to
57d4164
Compare
This commit introduces documentation that defines OLM support for Validating and Mutating Admission Webhooks.
awgreene
force-pushed
the
admission-webhooks-doc
branch
from
57d4164 to
584089b
Compare
|
When did/will OLM start supporting this? |
6 participants
This commit introduces documentation that defines OLM support for
Validating and Mutating Admission Webhooks.