Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SSA to create namespace and infra for integration test #2471

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

bachmanity1
Copy link
Contributor

Use server-side apply to create the namespace used for integration test. This, combined with withNamespaceNameSupplier, allows the use of a preconfigured namespace for integration tests. We need this because in our particular case some third-party infrastructure cannot be configured at the time of namespace creation and must be set up in advance.

@bachmanity1 bachmanity1 changed the title Use SSA to create test namespace and infra Use SSA to create namespace and infra for integration test Jul 16, 2024
Copy link
Collaborator

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @bachmanity1 , thank you!

@csviri csviri merged commit fcfaaf1 into operator-framework:main Jul 16, 2024
20 checks passed
@bachmanity1 bachmanity1 deleted the use-ssa-for-test-ns branch July 16, 2024 14:06
@bachmanity1
Copy link
Contributor Author

bachmanity1 commented Jul 16, 2024

Hi @csviri,

Thank you for the quick review and merge! Could we possibly release a patch version that includes this change? If releasing a patch version with this change isn't possible, could you please rerun the snapshot release action? It appears to have failed:

https://github.com/operator-framework/java-operator-sdk/actions/runs/9958117716/job/27511851273

Thanks!

@csviri
Copy link
Collaborator

csviri commented Jul 16, 2024

Hi @bachmanity1 , yes, restarted the snapshot release, and will make a release soon.

@csviri
Copy link
Collaborator

csviri commented Jul 17, 2024

released :) @bachmanity1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants