fix: change namespace starts processor on namespace change even if not leader #2344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t leader Signed-off-by: Attila Mészáros <[email protected]>
|
Would be a bit nicer to check if the instance is the leader, but in the current scope controller is unaware of the leader election, - - which is not necessarily bad layering, actually kinda of makes nice loose coupling. Will add tests, before marking it ready. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
gyfora
reviewed
Apr 12, 2024
Comment on lines
+387
to
+389
| if (eventProcessorWasRunning) { | ||
| eventProcessor.start(); | ||
| } |
There was a problem hiding this comment.
could it happen that at this point we are are already the leader (and accidentally not start processing) or the synchronised will take care of that
There was a problem hiding this comment.
exactly, synchronized takes care of that
gyfora
approved these changes
Apr 12, 2024
Signed-off-by: Attila Mészáros <[email protected]>
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.