Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: distinguish resources based on desired state #2252

Merged
merged 22 commits into from
Mar 13, 2024
Merged

feat: distinguish resources based on desired state #2252

merged 22 commits into from
Mar 13, 2024

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Feb 27, 2024

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 27, 2024
@csviri csviri self-assigned this Feb 27, 2024
@csviri csviri marked this pull request as ready for review February 27, 2024 14:38
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 27, 2024
@openshift-ci openshift-ci bot requested a review from adam-sandor February 27, 2024 14:38
@csviri csviri requested a review from metacosm February 27, 2024 14:38
@openshift-ci openshift-ci bot requested a review from andreaTP February 27, 2024 14:38
@csviri csviri linked an issue Feb 27, 2024 that may be closed by this pull request
Resource Discrimination Based on Desired State in Dependent Resources #2197
Closed
@csviri csviri mentioned this pull request Feb 27, 2024
Closed
@csviri
Copy link
Collaborator Author

csviri commented Feb 27, 2024

TODO:

  • docs,
  • release notes
  • Sample for external resources

@csviri csviri marked this pull request as draft February 27, 2024 15:03
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 27, 2024
@csviri csviri mentioned this pull request Feb 27, 2024
Open
@metacosm metacosm marked this pull request as ready for review February 28, 2024 10:30
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2024
@metacosm metacosm marked this pull request as draft February 28, 2024 10:32
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2024
@csviri csviri force-pushed the resource-discriminator-based-on-state branch from 826349b to e259186 Compare March 5, 2024 12:38
@csviri csviri marked this pull request as ready for review March 6, 2024 08:22
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 6, 2024
@openshift-ci openshift-ci bot requested a review from metacosm March 6, 2024 08:22
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 8, 2024
@metacosm metacosm force-pushed the resource-discriminator-based-on-state branch from d0d6874 to f523d24 Compare March 11, 2024 17:14
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 11, 2024
@metacosm metacosm force-pushed the resource-discriminator-based-on-state branch from f523d24 to d0d6874 Compare March 11, 2024 17:46
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 11, 2024
@csviri csviri force-pushed the resource-discriminator-based-on-state branch from d0d6874 to 61f7a1f Compare March 11, 2024 17:55
@csviri csviri merged commit 3365b73 into next Mar 13, 2024
20 checks passed
@csviri csviri deleted the resource-discriminator-based-on-state branch March 13, 2024 16:11
@metacosm metacosm mentioned this pull request Mar 21, 2024
Closed
csviri added a commit that referenced this pull request Apr 10, 2024
@csviri
feat: distinguish resources based on desired state (#2252)
358b88a 
Signed-off-by: Attila Mészáros <[email protected]>
metacosm pushed a commit that referenced this pull request Apr 10, 2024
@csviri @metacosm
feat: distinguish resources based on desired state (#2252)
93fcf49 
Signed-off-by: Attila Mészáros <[email protected]>
metacosm pushed a commit that referenced this pull request Apr 11, 2024
@csviri @metacosm
feat: distinguish resources based on desired state (#2252)
3b393e3 
Signed-off-by: Attila Mészáros <[email protected]>
csviri added a commit that referenced this pull request May 17, 2024
@csviri
feat: distinguish resources based on desired state (#2252)
2ad10e7 
Signed-off-by: Attila Mészáros <[email protected]>
csviri added a commit that referenced this pull request May 17, 2024
@csviri
feat: distinguish resources based on desired state (#2252)
9972e0e 
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
csviri added a commit that referenced this pull request May 21, 2024
@csviri
feat: distinguish resources based on desired state (#2252)
717d077 
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
csviri added a commit that referenced this pull request Jun 17, 2024
@csviri
feat: distinguish resources based on desired state (#2252)
9467d01 
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
csviri added a commit that referenced this pull request Jun 17, 2024
@csviri
feat: distinguish resources based on desired state (#2252)
3e0b3a4 
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
metacosm pushed a commit that referenced this pull request Jul 8, 2024
@csviri @metacosm
feat: distinguish resources based on desired state (#2252)
b986142 
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
metacosm pushed a commit that referenced this pull request Jul 9, 2024
@csviri @metacosm
feat: distinguish resources based on desired state (#2252)
35be41e 
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
metacosm pushed a commit that referenced this pull request Jul 12, 2024
@csviri @metacosm
feat: distinguish resources based on desired state (#2252)
27d2db6 
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
csviri added a commit that referenced this pull request Aug 8, 2024
@csviri
feat: distinguish resources based on desired state (#2252)
6e4cf34 
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri csviri mentioned this pull request Aug 14, 2024
Merged
csviri added a commit that referenced this pull request Aug 15, 2024
@csviri
feat: distinguish resources based on desired state (#2252)
0100b53 
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
metacosm pushed a commit that referenced this pull request Aug 29, 2024
@csviri @metacosm
feat: distinguish resources based on desired state (#2252)
368065d 
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri csviri mentioned this pull request Sep 17, 2024
Merged
csviri added a commit that referenced this pull request Sep 20, 2024
@csviri
feat: distinguish resources based on desired state (#2252)
6133448 
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
metacosm pushed a commit that referenced this pull request Oct 10, 2024
@csviri @metacosm
feat: distinguish resources based on desired state (#2252)
bbf0fbe 
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
metacosm pushed a commit that referenced this pull request Nov 5, 2024
@csviri @metacosm
feat: distinguish resources based on desired state (#2252)
d24d4ca 
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
metacosm pushed a commit that referenced this pull request Nov 6, 2024
@csviri @metacosm
feat: distinguish resources based on desired state (#2252)
5dd6e76 
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
csviri added a commit that referenced this pull request Nov 13, 2024
@csviri
feat: distinguish resources based on desired state (#2252)
4fb5552 
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
metacosm pushed a commit that referenced this pull request Nov 19, 2024
@csviri @metacosm
feat: distinguish resources based on desired state (#2252)
082de83 
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
metacosm pushed a commit that referenced this pull request Nov 20, 2024
@csviri @metacosm
feat: distinguish resources based on desired state (#2252)
3c11e6f 
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
metacosm pushed a commit that referenced this pull request Nov 27, 2024
@csviri @metacosm
feat: distinguish resources based on desired state (#2252)
4cd01d8 
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
This was referenced Dec 3, 2024
Merged
Closed
csviri added a commit that referenced this pull request Dec 6, 2024
@csviri
feat: distinguish resources based on desired state (#2252)
bacc1ca 
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metacosm metacosm metacosm approved these changes

@adam-sandor adam-sandor Awaiting requested review from adam-sandor

@andreaTP andreaTP Awaiting requested review from andreaTP

Assignees

@csviri csviri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resource Discrimination Based on Desired State in Dependent Resources
3 participants
@csviri @metacosm @openshift-merge-robot