Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve: filters accept super types #1940

Merged
merged 5 commits into from
Jun 14, 2023
Merged

improve: filters accept super types #1940

merged 5 commits into from
Jun 14, 2023

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Jun 13, 2023

No description provided.

@csviri csviri changed the title Filters super classes improve: filters accept super types Jun 13, 2023
@csviri csviri linked an issue Jun 13, 2023 that may be closed by this pull request
Methods such as withOnUpdateFilter should accept super types #1938
Closed
@csviri csviri self-assigned this Jun 13, 2023
@csviri csviri requested a review from metacosm June 13, 2023 08:59
@csviri csviri marked this pull request as draft June 13, 2023 09:08
@csviri csviri marked this pull request as ready for review June 13, 2023 10:16
@csviri
Copy link
Collaborator Author

csviri commented Jun 13, 2023

cc @shawkins

@shawkins
Copy link
Collaborator

LGTM, thanks @csviri

@metacosm
Copy link
Collaborator

Wondering if this has an impact on backwards compatibility.

@csviri
Copy link
Collaborator Author

csviri commented Jun 13, 2023 •
edited
Loading

Probably not, I guess most of the users use just the target resources. Might be more correct to target next version probably since still bit of an minor API change.

@shawkins
Copy link
Collaborator

Wondering if this has an impact on backwards compatibility.

There should not be, this is widening, not narrowing what is accepted. Are you worried about exotic scenarios such as users using reflection to find these methods?

csviri and others added 5 commits June 13, 2023 16:25
@csviri
improve: filters accept super types
88b830e
@csviri
fix
1daf930
@csviri
fix
f6cb762
@dependabot @csviri
chore(deps): bump micrometer-core from 1.11.0 to 1.11.1 (#1939)
e8533f8 
Bumps [micrometer-core](https://github.com/micrometer-metrics/micrometer) from 1.11.0 to 1.11.1.
- [Release notes](https://github.com/micrometer-metrics/micrometer/releases)
- [Commits](micrometer-metrics/micrometer@v1.11.0...v1.11.1)

---
updated-dependencies:
- dependency-name: io.micrometer:micrometer-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@csviri
move base to next
83a72bd
@csviri csviri changed the base branch from main to next June 13, 2023 14:29
@sonarcloud
Copy link

sonarcloud bot commented Jun 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 15 Code Smells

75.3% 75.3% Coverage
0.0% 0.0% Duplication

@csviri
Copy link
Collaborator Author

csviri commented Jun 13, 2023

(changed it to target next )

@metacosm
Copy link
Collaborator

Wondering if this has an impact on backwards compatibility.

There should not be, this is widening, not narrowing what is accepted. Are you worried about exotic scenarios such as users using reflection to find these methods?

You're right, my concern was unwarranted.

@csviri csviri merged commit 6b95603 into next Jun 14, 2023
@csviri csviri deleted the filters-super-classes branch June 14, 2023 07:11
csviri added a commit that referenced this pull request Jun 16, 2023
@csviri
improve: filters accept super types (#1940)
bfdb07e
csviri added a commit that referenced this pull request Jun 20, 2023
@csviri
improve: filters accept super types (#1940)
8eb131c
csviri added a commit that referenced this pull request Jun 21, 2023
@csviri
improve: filters accept super types (#1940)
69d5af2
metacosm pushed a commit that referenced this pull request Jun 23, 2023
@csviri @metacosm
improve: filters accept super types (#1940)
2098aec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metacosm metacosm metacosm approved these changes

Assignees

@csviri csviri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Methods such as withOnUpdateFilter should accept super types
3 participants
@csviri @shawkins @metacosm