matchers ignore list #1880
Merged
matchers ignore list #1880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@metacosm in a separate PR will change the behavior, in a way that Kubernetes Service will be a special case, but the default behavior will use equality matcher (if no objections). |
metacosm
force-pushed
the
matchers-ignore-list
branch
2 times, most recently
from
f431b34
to
a96e6ad
Compare
csviri
force-pushed
the
matchers-ignore-list
branch
from
85d344e
to
d16ac21
Compare
metacosm
requested changes
May 3, 2023
| public static <R extends HasMetadata> Result<R> match(R desired, R actualResource, | ||
| boolean considerMetadata) { | ||
| return match(desired, actualResource, considerMetadata, false); | ||
| return match(desired, actualResource, false, false, false); |
There was a problem hiding this comment.
You changed the implementation but didn't change the javadoc.
There was a problem hiding this comment.
but that did not change the behavior I believe
There was a problem hiding this comment.
One parameter got changed from true to false. If changing this doesn't change the behavior, then what's the point of the parameter? 😄
More seriously, though, before this commit the metadata was considered, now it's not anymore so the javadoc is not correct anymore with respect to the implementation.
There was a problem hiding this comment.
I'm checking this, but actually cannot see, where. So it is not considered on the main now. Maybe we can take a look offline.
csviri
force-pushed
the
matchers-ignore-list
branch
from
d16ac21
to
54fa804
Compare
|
Kudos, SonarCloud Quality Gate passed! |
[skip ci]
metacosm
approved these changes
May 4, 2023
csviri
added a commit
that referenced
this pull request
May 4, 2023
Co-authored-by: Chris Laprun <[email protected]>
csviri
added a commit
that referenced
this pull request
May 24, 2023
Co-authored-by: Chris Laprun <[email protected]>
csviri
added a commit
that referenced
this pull request
May 30, 2023
Co-authored-by: Chris Laprun <[email protected]> � Conflicts: � operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/GenericKubernetesResourceMatcher.java � operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/GenericKubernetesResourceMatcherTest.java
csviri
added a commit
that referenced
this pull request
May 31, 2023
Co-authored-by: Chris Laprun <[email protected]> � Conflicts: � operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/GenericKubernetesResourceMatcher.java � operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/GenericKubernetesResourceMatcherTest.java
csviri
added a commit
that referenced
this pull request
Jun 8, 2023
Co-authored-by: Chris Laprun <[email protected]> � Conflicts: � operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/GenericKubernetesResourceMatcher.java � operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/GenericKubernetesResourceMatcherTest.java
csviri
added a commit
that referenced
this pull request
Jun 16, 2023
Co-authored-by: Chris Laprun <[email protected]> � Conflicts: � operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/GenericKubernetesResourceMatcher.java � operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/GenericKubernetesResourceMatcherTest.java
csviri
added a commit
that referenced
this pull request
Jun 20, 2023
Co-authored-by: Chris Laprun <[email protected]> � Conflicts: � operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/GenericKubernetesResourceMatcher.java � operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/GenericKubernetesResourceMatcherTest.java
csviri
added a commit
that referenced
this pull request
Jun 21, 2023
Co-authored-by: Chris Laprun <[email protected]> � Conflicts: � operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/GenericKubernetesResourceMatcher.java � operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/GenericKubernetesResourceMatcherTest.java
metacosm
pushed a commit
that referenced
this pull request
Jun 23, 2023
Co-authored-by: Chris Laprun <[email protected]> � Conflicts: � operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/GenericKubernetesResourceMatcher.java � operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/GenericKubernetesResourceMatcherTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.