Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: sample of how to do unmodifiable part of dependent #1746

Merged
merged 2 commits into from
Feb 7, 2023
Merged

feat: sample of how to do unmodifiable part of dependent #1746

merged 2 commits into from
Feb 7, 2023

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Jan 31, 2023

No description provided.

@csviri csviri mentioned this pull request Jan 31, 2023
Closed
@csviri csviri self-assigned this Jan 31, 2023
@csviri csviri linked an issue Jan 31, 2023 that may be closed by this pull request
How to selectively define the fields to reconcile with DependentResources #1474
Closed
@csviri csviri mentioned this pull request Jan 31, 2023
Closed
@sonarcloud
Copy link

sonarcloud bot commented Jan 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@csviri csviri requested a review from metacosm January 31, 2023 12:45
@metacosm
Copy link
Collaborator

All these samples would be even better with a description of what they're supposed to be doing so that people can get an idea before looking at the code.

@csviri
Copy link
Collaborator Author

csviri commented Feb 6, 2023

All these samples would be even better with a description of what they're supposed to be doing so that people can get an idea before looking at the code.

Yep, should be probably a separate issue, either we could generate a summary page, or just link the test from the docs and better describe them there too.

But kind of an index + generated description would be beneficial.

@csviri csviri merged commit 9abcb37 into main Feb 7, 2023
@csviri csviri deleted the non-constant-part-in-resources branch February 7, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metacosm metacosm metacosm approved these changes

Assignees

@csviri csviri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to selectively define the fields to reconcile with DependentResources
2 participants
@csviri @metacosm