Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bom version after release #1442

Merged
merged 1 commit into from
Sep 5, 2022
Merged

fix: bom version after release #1442

merged 1 commit into from
Sep 5, 2022

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Sep 5, 2022

No description provided.

@csviri csviri self-assigned this Sep 5, 2022
@csviri csviri changed the title fix: bom version fix: bom version after release Sep 5, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@csviri csviri merged commit a08dc4e into main Sep 5, 2022
@csviri csviri deleted the fix-bom-version branch September 5, 2022 11:37
@honnix
Copy link
Contributor

honnix commented Sep 11, 2022

Not sure what I missed. I thought this should be updated automatically by maven release plugin. Also it seems 3.2.0 did not publish the bom artifact to maven central.

@honnix
Copy link
Contributor

honnix commented Sep 11, 2022

OK I see this now #1444. Sorry about that.

An alternative way could be setting -DprocessAllModules=true for mvn versions:set, but having a dedicated step seems to be better.

I guess there would be no backfill release for bom until 3.2.1 is out, right?

@csviri
Copy link
Collaborator Author

csviri commented Sep 12, 2022

probably not, but that will be done probably soon, since anyways there was a small bug with worfklows.

metacosm pushed a commit that referenced this pull request Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants