Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: split manifests into overlays #45

Merged
merged 1 commit into from
Apr 19, 2022
Merged

feat: split manifests into overlays #45

merged 1 commit into from
Apr 19, 2022

Conversation

SamoKopecky
Copy link
Member

Resolves #34

  • Rename peribolos-as-services to peribolos-as-service for created reosources since I think the s at the end was a typo
  • Create json6902 patch for dev/test overlays to update NODE_ENV variable
  • Update RBAC role to also include deployments, this is needed for the depoyment-config resource

@sesheta sesheta requested review from mimotej and tumido April 13, 2022 16:09
@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 13, 2022
@SamoKopecky SamoKopecky force-pushed the split-manifests branch 2 times, most recently from e487775 to e8eee25 Compare April 14, 2022 08:18
@SamoKopecky
Copy link
Member Author

/retest all

@sesheta
Copy link
Member

sesheta commented Apr 14, 2022

@SamoKopecky: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test pre-commit

Use /test all to run all jobs.

In response to this:

/retest all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tumido
tumido requested changes Apr 14, 2022
View reviewed changes
manifests/base/role.yaml Outdated Show resolved Hide resolved
manifests/overlays/dev/kustomization.yaml Outdated Show resolved Hide resolved
manifests/overlays/test/kustomization.yaml Outdated Show resolved Hide resolved
@SamoKopecky SamoKopecky force-pushed the split-manifests branch 3 times, most recently from 92f6942 to 3d34297 Compare April 14, 2022 17:01
@SamoKopecky
Create manifests directory structure, create patches
d4479d6 
- Add secret template to manifests
- Move imagestream manifest
- Update imagestream api version

Signed-off-by: SamoKopecky <[email protected]>
@SamoKopecky SamoKopecky requested a review from tumido April 14, 2022 17:09
@SamoKopecky
Copy link
Member Author

Thanks for the feedback, request changes are now committed.

tumido
tumido approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2022
@sesheta
Copy link
Member

sesheta commented Apr 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tumido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2022
@sesheta sesheta merged commit d9d2ae5 into operate-first:main Apr 19, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2022

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Marks issues as released label May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tumido tumido tumido approved these changes

@mimotej mimotej Awaiting requested review from mimotej

Assignees

@tumido tumido

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. released Marks issues as released size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split manifests into prod/test/dev overlays
3 participants
@SamoKopecky @sesheta @tumido