Replace banner.txt with new logo

[making]

#2737

[shakuzen]

We might want to wait on merging this for the outcome of the discussion on openzipkin vs zipkin in the logo.

[codefromthecrypt]

actually definitely the server should just be zipkin. I think it would be certainly incorrect here.

…

On Wed, Aug 7, 2019, 9:27 PM Tommy Ludwig ***@***.***> wrote: We might want to wait on merging this for the outcome of the discussion on openzipkin vs zipkin in the logo. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2738?email_source=notifications&email_token=AAAPVVZMLA6HBVHF2SGIZOLQDLEVFA5CNFSM4IJ4PBA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3YMS2I#issuecomment-519096681>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAPVV6F7ZWRBOBGTDWJ6TLQDLEVFANCNFSM4IJ4PBAQ> .

[making]

Updated

[codefromthecrypt]

ahead of the curve huh? :D

[making]

I tested banner.txt in a latest spring boot app.

[codefromthecrypt]

if you can verify this is correct still with the new logo content: openzipkin/openzipkin.github.io#142 then later or now we still need to update lens images

[codefromthecrypt]

only difference is if we think red or orange, I guess

[jeqo]

sadly, seems that orange is not available https://docs.spring.io/spring-boot/docs/current/api/org/springframework/boot/ansi/AnsiColor.html but I will let @making confirm if possible.
we might fallback to white as well.

[making]

@jeqo @adriancole as far as I know, orange is not supposed.

[codefromthecrypt]

I think black/white/grey is better than red when orange unsupported. Red is a more aggressive color.

can you raise an issue to support orange :)

[making]

I'll try to implement a new org.springframework.boot.ansi.AnsiElement so that it supports 256 colors.

Which color do you prefer? :)

You can get this table by

for i in $(seq 1 255);do printf "%03d \033[38;5;${i}mZipkin\033[0;00m\t" $i; if [ $(( $i % 10 )) -eq 0 ];then echo;fi ;done;echo

[making]

I think I managed to change the color :)

Let me update the source code later

[jorgheymans]

I think I managed to change the color :)

Let me update the source code later

Cool ! Will it work in a windows shell as well ?

[making]

I've just pushed the updated banner in 4ca0ae3.

@jorgheymans I don't have a Windows environment. Could you please give it a try?

[making]

In 4ca0ae3
I added ZipkinAnsi256Color, ZipkinAnsi256PropertySource and ZipkinBanner, then configured the banner programmatically as described in the boot doc in order to support 256 colors that is not available in Spring Boot out of the box now.
I'm thinking to contribute to Spring Boot but it wouldn't come to Spring Boot 2.1.x. So Zipkin needs to have these classes until a feature version.

[codefromthecrypt]

add a TODO to delete on spring boot 2.2 if that's when this is scheduled to be normally possible.

[making]

Updated in edebc31

[codefromthecrypt]

Will merge this on green.

Added issue to update lens #2806

[codefromthecrypt]

thanks again!

[making]

It's been merged in Spring Boot 2.2 :)
spring-projects/spring-boot#18264

[codefromthecrypt]

nice to change your shoes on occasion!