Adds MDCCurrentTraceContext for log correlation #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ryangardner I know you asked for this a year ago, but everything's coming together now |
codefromthecrypt
force-pushed
the
context-slf4j
branch
from
fa72226 to
eac8a4d
Compare
This adds trace and span IDs to the SLF4J Mapped Diagnostic Context (MDC)
so that you can search or aggregate logs accordingly.
To enable this, configure `brave.Tracing` with `MDCCurrentTraceContext`
like so:
```java
tracing = Tracing.newBuilder()
.currentTraceContext(MDCCurrentTraceContext.create())
...
.build();
```
Then, in your log configuration, you can use `traceId` and or `spanId`.
codefromthecrypt
force-pushed
the
context-slf4j
branch
from
eac8a4d to
40399d9
Compare
|
nice! |
|
Looks good to me. Whats up with the circle-ci failure? |
|
Unrelated flake but will have a look
…On 3 May 2017 04:02, "Brian Devins" ***@***.***> wrote:
Looks good to me. Whats up with the circle-ci failure?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#389 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD613KYN8YoOnsd5AklOtQW4bbRYyG_ks5r14vFgaJpZM4NOUva>
.
|
|
next release won't be until this weekend, so feel free to provide feedback after the fact. merged so people can play with snapshots |
|
bumped version to 4.3.0-SNAPSHOT |
|
Can this be extended to Log4j2 thread context? |
|
Can this be extended to Log4j2 thread context?
yes.. I already have an impl, just was waiting for someone to ask
|
|
Awesome! |
codefromthecrypt
pushed a commit
that referenced
this pull request
May 6, 2017
This adds trace and span IDs to the Log4J 2 Thread Context so that you
can search or aggregate logs accordingly.
To enable this, configure `brave.Tracing` with `ThreadContextCurrentTraceContext`
like so:
```java
tracing = Tracing.newBuilder()
.currentTraceContext(ThreadContextCurrentTraceContext.create())
...
.build();
```
See #389
codefromthecrypt
pushed a commit
that referenced
this pull request
May 7, 2017
This adds trace and span IDs to the Log4J 2 Thread Context so that you
can search or aggregate logs accordingly.
To enable this, configure `brave.Tracing` with `ThreadContextCurrentTraceContext`
like so:
```java
tracing = Tracing.newBuilder()
.currentTraceContext(ThreadContextCurrentTraceContext.create())
...
.build();
```
See #389
|
Currently trying to add the traceID into my logging for any HTTP request.. What is this logback configuration that is referenced(the only xml files I have are my pom.xml)? Also, because the decorator's create() methods are all deprecrated, should I be using the get() method instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds trace and span IDs to the SLF4J Mapped Diagnostic Context (MDC)
so that you can search or aggregate logs accordingly.
To enable this, configure
brave.TracingwithMDCCurrentTraceContextlike so:
Then, in your log configuration, you can use
traceIdand orspanId.Here's an example logback configuration:
When a trace is in progress, it would log statements like this:
Users could then copy/paste the trace ID into the zipkin UI, or use log
correlation to further debug a problem.
Fixes #150
See #369