Causal mask suboptimal HLO simplification #9867
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below is a common JAX code issue encountered when generating a Causal mask. The user either neglected to specify
dtype=bool
inones()
or mistakenly applied.astype(bool)
to the result oftril()
instead of toones()
. Consequently, the mask will be converted from f32 to bool, resulting in suboptimal HLO.Simplification:
Ne(select(Ge(a, b), ones, zeros), zeros) -> Ge(a, b)
Discussion: #9709