Skip to content

[XLA:Python] Add CudaArrayInterfaceToBuffer - #8237

Closed
pearu wants to merge 1 commit into
openxla:mainfrom
pearu:pearu/cuda_array_interface-importer
Closed

[XLA:Python] Add CudaArrayInterfaceToBuffer#8237
pearu wants to merge 1 commit into
openxla:mainfrom
pearu:pearu/cuda_array_interface-importer

Conversation

@pearu

@pearu pearu commented Jan 7, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

As in the title.

Required by jax-ml/jax#19233

@google-cla

google-cla Bot commented Jan 7, 2024

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions Bot added the kokoro:force-run Forces CI to rerun label Jan 7, 2024
@pearu pearu mentioned this pull request Jan 7, 2024
Merged
@kokoro-team kokoro-team removed the kokoro:force-run Forces CI to rerun label Jan 7, 2024
@github-actions github-actions Bot added the kokoro:force-run Forces CI to rerun label Jan 7, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Forces CI to rerun label Jan 7, 2024
@kamaljeeti

kamaljeeti commented Jan 8, 2024

Copy link
Copy Markdown
Contributor

Hi @pearu, can you sign up on this CLA provided below.
https://cla.developers.google.com/clas

@pearu

pearu commented Jan 10, 2024

Copy link
Copy Markdown
Contributor Author

@hawkinsp please review.

@kamaljeeti
kamaljeeti requested a review from penpornk January 16, 2024 04:30
@penpornk
penpornk requested a review from hawkinsp January 16, 2024 15:12
penpornk
penpornk requested changes Jan 16, 2024
View reviewed changes

@penpornk penpornk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! I have quick formatting comments.

Comment thread xla/python/py_array.cc Outdated
Comment thread xla/python/py_array.cc Outdated
@kamaljeeti

kamaljeeti commented Jan 23, 2024

Copy link
Copy Markdown
Contributor

Hi @pearu , can you have a look at the comments? Thanks.

@pearu
pearu force-pushed the pearu/cuda_array_interface-importer branch from 783217e to a73e3ba Compare January 23, 2024 11:07
@github-actions github-actions Bot added the kokoro:force-run Forces CI to rerun label Jan 23, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Forces CI to rerun label Jan 23, 2024
@pearu
pearu requested a review from penpornk January 23, 2024 11:11
@github-actions github-actions Bot added the kokoro:force-run Forces CI to rerun label Jan 23, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Forces CI to rerun label Jan 23, 2024
@pearu
pearu force-pushed the pearu/cuda_array_interface-importer branch from def4e60 to f303c2b Compare January 28, 2024 14:22
@github-actions github-actions Bot added the kokoro:force-run Forces CI to rerun label Jan 28, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Forces CI to rerun label Jan 28, 2024
@pearu

pearu commented Jan 29, 2024

Copy link
Copy Markdown
Contributor Author

@penpornk, this PR is ready for review.

penpornk
penpornk approved these changes Jan 29, 2024
View reviewed changes

@penpornk penpornk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay and thank you again for the PR!

@jvstokes

jvstokes commented Jan 29, 2024

Copy link
Copy Markdown
Contributor

Thank you for the PR, @pearu ! Could you also please update the python xla extension stub file to include cuda_array_interface_to_buffer, i.e. add it around here https://github.com/openxla/xla/blob/main/xla/python/xla_extension/__init__.pyi#L688

@pearu
pearu force-pushed the pearu/cuda_array_interface-importer branch from f303c2b to d5da61d Compare January 30, 2024 09:35
@github-actions github-actions Bot added the kokoro:force-run Forces CI to rerun label Jan 30, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Forces CI to rerun label Jan 30, 2024
@pearu

pearu commented Jan 30, 2024

Copy link
Copy Markdown
Contributor Author

Could you also please update the python xla extension stub file to include cuda_array_interface_to_buffer

@jvstokes yes, done.

penpornk
penpornk approved these changes Jan 30, 2024
View reviewed changes

@penpornk penpornk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update!

@pearu

pearu commented Feb 1, 2024

Copy link
Copy Markdown
Contributor Author

@penpornk could you check why Google internal checks failed?

@penpornk

penpornk commented Feb 1, 2024

Copy link
Copy Markdown
Member

@pearu It seems the submit was blocked because of some flaky internal tests. I've triggered the submission again now.

@pearu

pearu commented Feb 1, 2024

Copy link
Copy Markdown
Contributor Author

@penpornk thanks for checking! Notice that there is a conflict, let me fix that first.

@pearu
pearu force-pushed the pearu/cuda_array_interface-importer branch from d5da61d to b2f5fdc Compare February 2, 2024 09:57
@github-actions github-actions Bot added the kokoro:force-run Forces CI to rerun label Feb 2, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Forces CI to rerun label Feb 2, 2024
penpornk
penpornk approved these changes Feb 2, 2024
View reviewed changes

@penpornk penpornk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for resolving the conflict!

copybara-service Bot pushed a commit to tensorflow/tensorflow that referenced this pull request Feb 2, 2024
@pearu @tensorflower-gardener
PR #8237: [XLA:Python] Add CudaArrayInterfaceToBuffer
73e6c46 
Imported from GitHub PR openxla/xla#8237

As in the title.

Required by jax-ml/jax#19233
Copybara import of the project:

--
b2f5fdc973f50426ff3dbc9c73e860582c69c0d3 by Pearu Peterson <pearu.peterson@gmail.com>:

Add CudaArrayInterfaceToBuffer

Merging this change closes #8237

PiperOrigin-RevId: 603666956
copybara-service Bot pushed a commit that referenced this pull request Feb 2, 2024
@tensorflower-gardener @copybara-github
Replaces the strategy equivalence logic with strategy *dominance* logic.
14d9384 
FUTURE_COPYBARA_INTEGRATE_REVIEW=#8237 from pearu:pearu/cuda_array_interface-importer b2f5fdc
PiperOrigin-RevId: 603076951
@copybara-service copybara-service Bot mentioned this pull request Feb 2, 2024
Merged
@copybara-service copybara-service Bot closed this in 2af94e8 Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@penpornk penpornk penpornk approved these changes
@hawkinsp hawkinsp Awaiting requested review from hawkinsp

Assignees

@xla-rotation xla-rotation

@kamaljeeti kamaljeeti

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pearu @kamaljeeti @jvstokes @penpornk @kokoro-team @xla-rotation