Skip to content

[ROCM] band-aid: disable symm memory for RCCL #46895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pemeliya wants to merge 3 commits into from
Closed

[ROCM] band-aid: disable symm memory for RCCL #46895

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3e23a78
disable rccl symm memory
pemeliya Aug 7, 2026
ae6d9dc
revert
pemeliya Aug 11, 2026
c682659
revert
pemeliya Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions xla/backends/gpu/collectives/rccl_symmetric_memory.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,16 +39,14 @@ RcclSymmetricMemory::Create(ncclComm_t comm,
"Create RCCL symmetric memory on comm=%p from: ptr=%p; size=%ld", comm,
addr.opaque(), addr.size());

ncclWindow_t win;
XLA_RCCL_RETURN_IF_ERROR(ncclCommWindowRegister(
comm, addr.opaque(), addr.size(), &win, NCCL_WIN_COLL_SYMMETRIC));

ncclWindow_t win = nullptr;
// NOTE: ncclCommWindowRegister is not supported in RCCL yet: it fails loudly
// or just returns NULL window.
return absl::WrapUnique(new RcclSymmetricMemory(comm, win, addr));
}

RcclSymmetricMemory::~RcclSymmetricMemory() {
VLOG(3) << absl::StrFormat("Destroy %v", *this);
XLA_RCCL_LOG_IF_ERROR(ncclCommWindowDeregister(comm_, win_));
}

stream_executor::DeviceAddressBase RcclSymmetricMemory::addr() const {
Expand Down
Loading