Skip to content

PR #21375: [ds-fusion] Get While loop analysis with copy fusion #21376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2025
Merged

PR #21375: [ds-fusion] Get While loop analysis with copy fusion #21376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion xla/hlo/analysis/while_loop_analysis.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ static std::optional<int64_t> GetUniqueGTEDependenceIndex(
[](const HloInstruction* inst) -> ReplaceType {
return ReplaceType::kReplaceParam;
},
/*cross_computation=*/false, /*inline_calls_and_fusions=*/false,
/*cross_computation=*/false, /*inline_calls_and_fusions=*/true,
/*run_verifier=*/false);
HloComputation* entry = extracted->entry_computation();

Expand Down
41 changes: 41 additions & 0 deletions xla/hlo/analysis/while_loop_analysis_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -953,5 +953,46 @@ TEST_F(WhileLoopAnalysisTest,
EXPECT_EQ(trip_count, std::nullopt);
}

TEST_F(WhileLoopAnalysisTest, GetIndvarIndexShouldWorkWhenParamIsCopied) {
const char* hlo = R"(
HloModule test

fused_copy {
param.1 = (s32[],s32[]) parameter(0)
ROOT copy = (s32[], s32[]) copy(param.1)
}

body {
param.1 = (s32[], s32[]) parameter(0)
copy_fusion = (s32[], s32[]) fusion(param.1), kind=kInput, calls=fused_copy
iter.1 = s32[] get-tuple-element(copy_fusion), index=0
c.1 = s32[] constant(1)
add.1 = s32[] add(iter.1, c.1)
data.1 = s32[] get-tuple-element(copy_fusion), index=1
ROOT tuple = (s32[], s32[]) tuple(add.1, data.1)
}

condition {
param = (s32[], s32[]) parameter(0)
iter = s32[] get-tuple-element(param), index=0
c.10 = s32[] constant(10)
ROOT compare = pred[] compare(iter, c.10), direction=LT
}

ENTRY main {
c0 = s32[] constant(0)
data = s32[] parameter(0)
tuple = (s32[], s32[]) tuple(c0, data)
ROOT while = (s32[], s32[]) while(tuple), body=body, condition=condition
}
)";

TF_ASSERT_OK_AND_ASSIGN(std::unique_ptr<HloModule> m,
ParseAndReturnVerifiedModule(hlo));
HloInstruction* while_op = m->entry_computation()->root_instruction();
ASSERT_EQ(while_op->opcode(), HloOpcode::kWhile);
EXPECT_EQ(GetLoopInductionVarTupleIdx(while_op), 0);
}

} // namespace
} // namespace xla
Loading