Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symlink hermetic cuda headers to permit clang cuda version detection #16882

Closed
wants to merge 1 commit into from
Closed

Symlink hermetic cuda headers to permit clang cuda version detection #16882

wants to merge 1 commit into from

Conversation

tchatow
Copy link
Contributor

@tchatow tchatow commented Sep 6, 2024

Fixes #16877

@NaiyerRizz NaiyerRizz self-assigned this Sep 9, 2024
@NaiyerRizz NaiyerRizz added the kokoro:force-run Forces CI to rerun label Sep 9, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Forces CI to rerun label Sep 9, 2024
@dimitar-asenov dimitar-asenov requested review from beckerhe and removed request for mooskagh September 16, 2024 14:17
@beckerhe
Copy link
Member

Looks good to me, but I would like @ybaturina to have a look.

@thomasjoerg
Copy link
Member

ybaturina is OOO.
@beckerhe do you have enough context to take over?

@beckerhe
Copy link
Member

ybaturina is OOO. @beckerhe do you have enough context to take over?

I believe Yulia's ask from the comment chain above still stands. Once that's resolved it can be merged.

@beckerhe beckerhe added the kokoro:run Runs CI if PR is new label Sep 25, 2024
@kokoro-team kokoro-team removed the kokoro:run Runs CI if PR is new label Sep 25, 2024
@beckerhe
Copy link
Member

Thank you. I think this is good to go but would like to trigger a new run of the CI. Unfortunately the PR needs to be synced to HEAD due to a breakage on main that has been fixed by now.

I don't have the permission to sync the PR. @thomasjoerg or @dimitar-asenov, can you sync the PR and approve a run of the CI?

copybara-service bot pushed a commit to google/tsl that referenced this pull request Sep 25, 2024
@tchatow @copybara-github
PR #16882: Symlink hermetic cuda headers to permit clang cuda version…
f762ef1 
… detection

Imported from GitHub PR openxla/xla#16882

Fixes #16877
Copybara import of the project:

--
1ff356ac0870002b369c3ec09547aae2a62c70e2 by tchatow <[email protected]>:

Symlink hermetic cuda headers to permit clang cuda version detection

Fixes #16877

Merging this change closes #16882

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#16882 from tchatow:patch-1 1ff356ac0870002b369c3ec09547aae2a62c70e2
PiperOrigin-RevId: 678579231
@copybara-service copybara-service bot mentioned this pull request Sep 25, 2024
Merged
copybara-service bot pushed a commit that referenced this pull request Sep 25, 2024
@tchatow @Google-ML-Automation
PR #16882: Symlink hermetic cuda headers to permit clang cuda version…
feeddff 
… detection

Imported from GitHub PR #16882

Fixes #16877
Copybara import of the project:

--
1ff356a by tchatow <[email protected]>:

Symlink hermetic cuda headers to permit clang cuda version detection

Fixes #16877

Merging this change closes #16882

FUTURE_COPYBARA_INTEGRATE_REVIEW=#16882 from tchatow:patch-1 1ff356a
PiperOrigin-RevId: 678579231
@copybara-service copybara-service bot mentioned this pull request Sep 25, 2024
Merged
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Sep 25, 2024
@tchatow @tensorflower-gardener
PR #16882: Symlink hermetic cuda headers to permit clang cuda version…
27c78ab 
… detection

Imported from GitHub PR openxla/xla#16882

Fixes #16877
Copybara import of the project:

--
1ff356ac0870002b369c3ec09547aae2a62c70e2 by tchatow <[email protected]>:

Symlink hermetic cuda headers to permit clang cuda version detection

Fixes #16877

Merging this change closes #16882

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#16882 from tchatow:patch-1 1ff356ac0870002b369c3ec09547aae2a62c70e2
PiperOrigin-RevId: 678579231
@copybara-service copybara-service bot mentioned this pull request Sep 25, 2024
Merged
@tchatow
Copy link
Contributor Author

tchatow commented Sep 27, 2024

Rebased

@dimitar-asenov
Copy link
Member

Thanks, Sorry for the delay on submitting this. I hope to have it in today.

copybara-service bot pushed a commit that referenced this pull request Sep 27, 2024
@tchatow @Google-ML-Automation
PR #16882: Symlink hermetic cuda headers to permit clang cuda version…
814e905 
… detection

Imported from GitHub PR #16882

Fixes #16877
Copybara import of the project:

--
1ff356a by tchatow <[email protected]>:

Symlink hermetic cuda headers to permit clang cuda version detection

Fixes #16877

Merging this change closes #16882

FUTURE_COPYBARA_INTEGRATE_REVIEW=#16882 from tchatow:patch-1 1ff356a
PiperOrigin-RevId: 678579231
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Sep 27, 2024
@tchatow @tensorflower-gardener
PR #16882: Symlink hermetic cuda headers to permit clang cuda version…
c9ef27e 
… detection

Imported from GitHub PR openxla/xla#16882

Fixes #16877
Copybara import of the project:

--
1ff356ac0870002b369c3ec09547aae2a62c70e2 by tchatow <[email protected]>:

Symlink hermetic cuda headers to permit clang cuda version detection

Fixes #16877

Merging this change closes #16882

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#16882 from tchatow:patch-1 1ff356ac0870002b369c3ec09547aae2a62c70e2
PiperOrigin-RevId: 678579231
copybara-service bot pushed a commit to google/tsl that referenced this pull request Sep 27, 2024
@tchatow @copybara-github
PR #16882: Symlink hermetic cuda headers to permit clang cuda version…
d54ddc5 
… detection

Imported from GitHub PR openxla/xla#16882

Fixes #16877
Copybara import of the project:

--
1ff356ac0870002b369c3ec09547aae2a62c70e2 by tchatow <[email protected]>:

Symlink hermetic cuda headers to permit clang cuda version detection

Fixes #16877

Merging this change closes #16882

PiperOrigin-RevId: 679764212
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Sep 27, 2024
@tchatow @tensorflower-gardener
PR #16882: Symlink hermetic cuda headers to permit clang cuda version…
3f4b2fd 
… detection

Imported from GitHub PR openxla/xla#16882

Fixes #16877
Copybara import of the project:

--
1ff356ac0870002b369c3ec09547aae2a62c70e2 by tchatow <[email protected]>:

Symlink hermetic cuda headers to permit clang cuda version detection

Fixes #16877

Merging this change closes #16882

PiperOrigin-RevId: 679764212
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybaturina ybaturina ybaturina left review comments

@beckerhe beckerhe beckerhe approved these changes

@dimitar-asenov dimitar-asenov dimitar-asenov approved these changes

@NaiyerRizz NaiyerRizz Awaiting requested review from NaiyerRizz

Assignees

@NaiyerRizz NaiyerRizz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clang cannot detect hermetic cuda version
7 participants
@tchatow @beckerhe @thomasjoerg @dimitar-asenov @ybaturina @kokoro-team @NaiyerRizz