[ROCm] Triton in XLA for ROCm - gemm rewriter triton related changes.#10510
Closed
zoranjovanovic-ns wants to merge 1 commit intoopenxla:mainfrom
Closed
[ROCm] Triton in XLA for ROCm - gemm rewriter triton related changes.#10510zoranjovanovic-ns wants to merge 1 commit intoopenxla:mainfrom
zoranjovanovic-ns wants to merge 1 commit intoopenxla:mainfrom
Conversation
tdanyluk
approved these changes
Mar 14, 2024
Contributor
tdanyluk
left a comment
tdanyluk
left a comment
There was a problem hiding this comment.
This looks good to me, thank you.
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Mar 14, 2024
…ed changes. Imported from GitHub PR openxla/xla#10510 First commit of the series for enabling Triton in XLA for ROCm . Copybara import of the project: -- f680e98aa6908d02021bc0c8bb3d24edfc6b2a5d by Zoran Jovanovic <zjovanov@amd.com>: [ROCm] Triton in XLA for ROCm - gemm rewriter triton related changes. Merging this change closes #10510 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#10510 from ROCm:rocm_triton_backend f680e98aa6908d02021bc0c8bb3d24edfc6b2a5d PiperOrigin-RevId: 615707894
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Mar 14, 2024
…ed changes. Imported from GitHub PR openxla/xla#10510 First commit of the series for enabling Triton in XLA for ROCm . Copybara import of the project: -- f680e98aa6908d02021bc0c8bb3d24edfc6b2a5d by Zoran Jovanovic <zjovanov@amd.com>: [ROCm] Triton in XLA for ROCm - gemm rewriter triton related changes. Merging this change closes #10510 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#10510 from ROCm:rocm_triton_backend f680e98aa6908d02021bc0c8bb3d24edfc6b2a5d PiperOrigin-RevId: 615707894
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Mar 14, 2024
…ed changes. Imported from GitHub PR openxla/xla#10510 First commit of the series for enabling Triton in XLA for ROCm . Copybara import of the project: -- f680e98aa6908d02021bc0c8bb3d24edfc6b2a5d by Zoran Jovanovic <zjovanov@amd.com>: [ROCm] Triton in XLA for ROCm - gemm rewriter triton related changes. Merging this change closes #10510 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#10510 from ROCm:rocm_triton_backend f680e98aa6908d02021bc0c8bb3d24edfc6b2a5d PiperOrigin-RevId: 615707894
Contributor
|
@tdanyluk we notice there is a conflict, but there is a PR from copybara-service to merge now. We wonder shall we resolve this conflict and rebase it again? which I think might need you to approve again? |
Contributor
|
Yes, could you re-base and I'll re-approve? |
zoranjovanovic-ns
force-pushed
the
rocm_triton_backend
branch
from
f680e98 to
832d725
Compare
Contributor
Author
@cheshire rebased and pushed. |
cheshire
approved these changes
Mar 15, 2024
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Mar 15, 2024
…ed changes. Imported from GitHub PR openxla/xla#10510 First commit of the series for enabling Triton in XLA for ROCm . Copybara import of the project: -- 832d7253db1f8972862252f034b216d1eed1da29 by Zoran Jovanovic <zjovanov@amd.com>: [ROCm] Triton in XLA for ROCm - gemm rewriter triton related changes. Merging this change closes #10510 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#10510 from ROCm:rocm_triton_backend 832d7253db1f8972862252f034b216d1eed1da29 PiperOrigin-RevId: 615707894
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Mar 15, 2024
…ed changes. Imported from GitHub PR openxla/xla#10510 First commit of the series for enabling Triton in XLA for ROCm . Copybara import of the project: -- 832d7253db1f8972862252f034b216d1eed1da29 by Zoran Jovanovic <zjovanov@amd.com>: [ROCm] Triton in XLA for ROCm - gemm rewriter triton related changes. Merging this change closes #10510 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#10510 from ROCm:rocm_triton_backend 832d7253db1f8972862252f034b216d1eed1da29 PiperOrigin-RevId: 615707894
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Mar 15, 2024
…ed changes. Imported from GitHub PR openxla/xla#10510 First commit of the series for enabling Triton in XLA for ROCm . Copybara import of the project: -- 832d7253db1f8972862252f034b216d1eed1da29 by Zoran Jovanovic <zjovanov@amd.com>: [ROCm] Triton in XLA for ROCm - gemm rewriter triton related changes. Merging this change closes #10510 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#10510 from ROCm:rocm_triton_backend 832d7253db1f8972862252f034b216d1eed1da29 PiperOrigin-RevId: 615707894
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Mar 15, 2024
…ed changes. Imported from GitHub PR openxla/xla#10510 First commit of the series for enabling Triton in XLA for ROCm . Copybara import of the project: -- 832d7253db1f8972862252f034b216d1eed1da29 by Zoran Jovanovic <zjovanov@amd.com>: [ROCm] Triton in XLA for ROCm - gemm rewriter triton related changes. Merging this change closes #10510 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#10510 from ROCm:rocm_triton_backend 832d7253db1f8972862252f034b216d1eed1da29 PiperOrigin-RevId: 615707894
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Mar 15, 2024
…ed changes. Imported from GitHub PR openxla/xla#10510 First commit of the series for enabling Triton in XLA for ROCm . Copybara import of the project: -- 832d7253db1f8972862252f034b216d1eed1da29 by Zoran Jovanovic <zjovanov@amd.com>: [ROCm] Triton in XLA for ROCm - gemm rewriter triton related changes. Merging this change closes #10510 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#10510 from ROCm:rocm_triton_backend 832d7253db1f8972862252f034b216d1eed1da29 PiperOrigin-RevId: 615707894
Contributor
Author
|
@cheshire Do you know what is blocking PR from being merged? |
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 18, 2024
…ed changes. Imported from GitHub PR #10510 First commit of the series for enabling Triton in XLA for ROCm . Copybara import of the project: -- 832d725 by Zoran Jovanovic <zjovanov@amd.com>: [ROCm] Triton in XLA for ROCm - gemm rewriter triton related changes. Merging this change closes #10510 FUTURE_COPYBARA_INTEGRATE_REVIEW=#10510 from ROCm:rocm_triton_backend 832d725 PiperOrigin-RevId: 616862111
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Mar 18, 2024
…ed changes. Imported from GitHub PR openxla/xla#10510 First commit of the series for enabling Triton in XLA for ROCm . Copybara import of the project: -- 832d7253db1f8972862252f034b216d1eed1da29 by Zoran Jovanovic <zjovanov@amd.com>: [ROCm] Triton in XLA for ROCm - gemm rewriter triton related changes. Merging this change closes #10510 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#10510 from ROCm:rocm_triton_backend 832d7253db1f8972862252f034b216d1eed1da29 PiperOrigin-RevId: 616862111
Contributor
|
There are some internal failures, but nothing major, I'm trying to submit it. |
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 20, 2024
…ed changes. Imported from GitHub PR #10510 First commit of the series for enabling Triton in XLA for ROCm . Copybara import of the project: -- 832d725 by Zoran Jovanovic <zjovanov@amd.com>: [ROCm] Triton in XLA for ROCm - gemm rewriter triton related changes. Merging this change closes #10510 FUTURE_COPYBARA_INTEGRATE_REVIEW=#10510 from ROCm:rocm_triton_backend 832d725 PiperOrigin-RevId: 616862111
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Mar 20, 2024
…ed changes. Imported from GitHub PR openxla/xla#10510 First commit of the series for enabling Triton in XLA for ROCm . Copybara import of the project: -- 832d7253db1f8972862252f034b216d1eed1da29 by Zoran Jovanovic <zjovanov@amd.com>: [ROCm] Triton in XLA for ROCm - gemm rewriter triton related changes. Merging this change closes #10510 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#10510 from ROCm:rocm_triton_backend 832d7253db1f8972862252f034b216d1eed1da29 PiperOrigin-RevId: 616862111
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Mar 20, 2024
…ed changes. Imported from GitHub PR openxla/xla#10510 First commit of the series for enabling Triton in XLA for ROCm . Copybara import of the project: -- 832d7253db1f8972862252f034b216d1eed1da29 by Zoran Jovanovic <zjovanov@amd.com>: [ROCm] Triton in XLA for ROCm - gemm rewriter triton related changes. Merging this change closes #10510 PiperOrigin-RevId: 617500238
steeve
pushed a commit
to zml/xla
that referenced
this pull request
Aug 30, 2024
…n related changes. Imported from GitHub PR openxla#10510 First commit of the series for enabling Triton in XLA for ROCm . Copybara import of the project: -- 832d725 by Zoran Jovanovic <zjovanov@amd.com>: [ROCm] Triton in XLA for ROCm - gemm rewriter triton related changes. Merging this change closes openxla#10510 COPYBARA_INTEGRATE_REVIEW=openxla#10510 from ROCm:rocm_triton_backend 832d725 PiperOrigin-RevId: 617500238
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First commit of the series for enabling Triton in XLA for ROCm .