Add Home Assistant device tracker#5701
Conversation
| @@ -0,0 +1,5 @@ | |||
| config hass 'global' | |||
| option host '1.2.3.4:8123' | |||
There was a problem hiding this comment.
if you must do this, use something.example.org instead of 1.2.3.4
There was a problem hiding this comment.
I think a local-only IP would be better than a DNS name that could be registered at some point, but yeah, 1.2.3.4 is a bad idea.
There was a problem hiding this comment.
No, I literally meant "something.example.org" example.{com,org,net} are permanently reserved: https://tools.ietf.org/html/rfc2606 no-one can register them :)
There was a problem hiding this comment.
The TLD example. is also reserved, so I used that.
|
|
||
| logger -t $0 -p info "Starting up" | ||
|
|
||
| source /usr/lib/hass/functions.sh |
There was a problem hiding this comment.
you've "" quoted above, but not here. I don't care which you use, but consistency is nice.
There was a problem hiding this comment.
you're right, just copied the upper part everywhere.
|
A complete non-technical feedback regarding your chosen package name "hass", an ugly german word which means "hate"/"hatred". In times of Trump, alternative facts and hatred of foreigners not a good choice ... just my very personal reflection as I first saw your PR. |
|
@dibdot it's not this packager's choice, it's home assistant itself. => hass.io "Home ASSistant" I'd say using the "hass" name is most consistent and least surprising for the user. |
|
@karlp thanks for clarification, still I find this name quite awful (as a german native speaker). |
|
I'm German myself, so the association is certainly not lost on me. However,
'hass' and 'HA' are the usual abbreviations, but only 'hass' is unambiguous
about the actual software package referenced.
Am 04.03.2018 3:50 nachm. schrieb "Dirk Brenken" <notifications@github.com>:
… A complete non-technical feedback regarding your chosen package name
"hass", an ugly german word which means "hate"/"hatred". In times of Trump,
alternative facts and hatred of foreigners not a good choice ... just my
very personal reflection as I first saw your PR.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5701 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAzvhzgfrmXQAO2mYLQM3QZONHcg5-hrks5ta_8agaJpZM4Sacce>
.
|
Signed-off-by: Johannes Falke <johannesfalke@googlemail.com>
|
any news on this? |
|
Would like to see this integrated 😁 |
| define Package/hass | ||
| SECTION:=net | ||
| CATEGORY:=Network | ||
| TITLE:=Wireless device tracker for Home Assistant |
There was a problem hiding this comment.
ok, I missed this earlier. If this package is just the wireless device tracker, and not Home Assistant itself, then Shouldn't the package name be something like "hass-device-tracker" or something? not just "hass" itself?
| @@ -0,0 +1,5 @@ | |||
| config hass 'global' | |||
| option host 'ip.or.name.example:8123' | |||
| option pw '' | |||
There was a problem hiding this comment.
if that's password, please just use password, instead of making people guess.
| stop_service() { | ||
| for pid in $(all_child_pids $(cat $PIDFILE)); do | ||
| kill $pid | ||
| done |
There was a problem hiding this comment.
what did you do that procd isn't handling this for you? consider fixing your scripts that you don't need this sort of procedure to die politely.
There was a problem hiding this comment.
The way I'm spawning processes, procd does not correctly kill all child processes, that's why I wrote this.
| reload_service() | ||
| { | ||
| stop | ||
| start |
There was a problem hiding this comment.
99% sure you don't need this, as you're doing the default implentation.
|
@karlp Thanks so much for pushing this forward 🥇 |
|
Thanks for the feedback, I'll address those issues and comment back here when I think it's actually ready for merging. |
|
Any update on this? |
|
@mueslo ping any progress on this? |
|
bump please? :) |
|
The most forgotten 😅😅😅 |
11 participants
Maintainer: me
Compile tested: LEDE Reboot 17.01.2 r3435-65eec8bd5f
Run tested: LEDE Reboot 17.01.2 r3435-65eec8bd5f, tested locally
Description:
New package that notifies Home Assistant on hostapd events for presence detection. See also: https://github.com/mueslo/openwrt_hass_devicetracker