Skip to content

Conversation

@vooon
Copy link
Contributor

@vooon vooon commented Mar 22, 2025

Maintainer: me
Compile tested: x86_64, OpenWrt master d63663601d
Run tested: x86_64, Master, camera's continue to work

Description:

  • Update version to 1.9.9
  • Add patches to fix build with CGO=0
  • Fix excludes to drop example binaries

@vooon
Copy link
Contributor Author

vooon commented Mar 22, 2025

https://github.com/AlexxIT/go2rtc/tree/master/pkg/v4l2/device

Unbildable!

package github.com/AlexxIT/go2rtc/pkg/v4l2/device: C source files not allowed when not using cgo or SWIG: videodev2_arch.c

@vooon vooon marked this pull request as draft March 22, 2025 16:06
@vooon vooon marked this pull request as ready for review May 30, 2025 15:33
@vooon
Copy link
Contributor Author

vooon commented May 30, 2025

CC: friendly ping @BKPepe @neheb @1715173329

I've fixed build and have tested on x86 - all goes well.

@1715173329
Copy link
Member

On mips and riscv64:

2025-05-31T10:02:19.8258076Z github.com/AlexxIT/go2rtc/pkg/v4l2/device
2025-05-31T10:02:19.8688017Z # github.com/AlexxIT/go2rtc/pkg/v4l2/device
2025-05-31T10:02:19.8702264Z ../../pkg/v4l2/device/device.go:37:7: undefined: v4l2_capability
2025-05-31T10:02:19.8704098Z ../../pkg/v4l2/device/device.go:38:24: undefined: VIDIOC_QUERYCAP
2025-05-31T10:02:19.8704720Z ../../pkg/v4l2/device/device.go:53:9: undefined: v4l2_fmtdesc
2025-05-31T10:02:19.8705676Z ../../pkg/v4l2/device/device.go:55:11: undefined: V4L2_BUF_TYPE_VIDEO_CAPTURE
2025-05-31T10:02:19.8706531Z ../../pkg/v4l2/device/device.go:57:25: undefined: VIDIOC_ENUM_FMT
2025-05-31T10:02:19.8707166Z ../../pkg/v4l2/device/device.go:74:9: undefined: v4l2_frmsizeenum
2025-05-31T10:02:19.8707810Z ../../pkg/v4l2/device/device.go:78:25: undefined: VIDIOC_ENUM_FRAMESIZES
2025-05-31T10:02:19.8708670Z ../../pkg/v4l2/device/device.go:85:16: undefined: V4L2_FRMSIZE_TYPE_DISCRETE
2025-05-31T10:02:19.8709342Z ../../pkg/v4l2/device/device.go:99:9: undefined: v4l2_frmivalenum
2025-05-31T10:02:19.8710034Z ../../pkg/v4l2/device/device.go:105:25: undefined: VIDIOC_ENUM_FRAMEINTERVALS
2025-05-31T10:02:19.8710658Z ../../pkg/v4l2/device/device.go:105:25: too many errors

Missing dependency or unsupported platform?

@vooon
Copy link
Contributor Author

vooon commented Jun 1, 2025

@1715173329 hmm, i thought second patch from master should fix riscv64. MIPS most likely not supported.

New plugin which works with Video4Linux interface is arch dependant.

@vooon vooon force-pushed the go2rtc-1.9.9 branch 2 times, most recently from 35b0938 to f8a0c4f Compare June 1, 2025 16:55
- Update version to 1.9.9
- Add patch to fix build with CGO=0
- Add patch to support RISC-V 64
- Fix excludes not to include examples

Signed-off-by: Vladimir Ermakov <[email protected]>
@vooon
Copy link
Contributor Author

vooon commented Jun 1, 2025

@1715173329 i've updated patch set to include RV64 PR and fix to build on MIPS 24k (non-mipsel).

@BKPepe
Copy link
Member

BKPepe commented Jun 1, 2025

So many patches, have you reached upstream repository about them? Would be nice to have them upstreamed.🙏

@vooon
Copy link
Contributor Author

vooon commented Jun 1, 2025

@BKPepe RV64 patches must be incorporated in AlexxIT/go2rtc#1651 (namely 3, 4 & 5).

Patch 2 is already in master, but it actually requires patch 6 too.

@1715173329 1715173329 merged commit bb9dca2 into openwrt:master Jun 5, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants