Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lpac: fix the wrapper #25036

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

lpac: fix the wrapper #25036

wants to merge 1 commit into from

Conversation

bam80
Copy link
Contributor

@bam80 bam80 commented Sep 25, 2024

fixes openwrt#25035 

Signed-off-by: Andrey Butirsky <[email protected]>
@blocktrron
Copy link
Member

blocktrron commented Sep 26, 2024

Please package up the wrapper to have the binary path configurable instead of removing the UCI handling for lpac. This defeats the purpose of having the eSIM management configurable in uci in the first place.

Also please add a more descriptive description to the change.

Compromise for me would be to put uci handling as ulpac. See the commit here for configuring the binary path: #25035 (comment)

@bam80
Copy link
Contributor Author

bam80 commented Sep 26, 2024

@blocktrron that shouldn't be needed in the first place, I do not think it's acceptable solution.
Instead, you name your wrapper differently, I do not see how it defeats anything.

Compromise for me would be to put uci handling as ulpac

That would be fine, would you do the fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lpac: lpac-libmbim-wrapper doesn't work
2 participants