-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cni-protocol: new package #20515
cni-protocol: new package #20515
Conversation
This a no-go? It has been pending here now for some time. |
I think this can be added into the existing cni-plugins package directly. |
@1715173329 I could do that. Personally, I don't use it with cni anymore, as I have moved to netavark (podman moving away from cni...) - but for the moment rust-lang support is still making it's way to openwrt, so I haven't made a PR on netavark package, as it requires language support that doesn't exist yet. Maybe I should put it on cni for now and later when rust-lang is ready, separate it..? |
if you gonna reuse it with netavark, then I agree to keep this separated. |
Yes, I do. My package is here. But as I said, it requires rust-lang support to build. And here's my feature request on firewall driver support for podman. And here's my PR for letting system manage firewall on netavark. That's already merged to netavark. I am trying to participate on the early train in favour of openwrt to keep up the pace. Docker (and lxc and others?) likely will stay with cni. Since podman v4.4.0, netavark is recommended and cni deprecation has begun, like it saids on release notes of v4.4.0. And I don't think we should need identical protocol for netavark, or any other other similar equillavent and I think it's not a real world problem if protocol is named as cni; it sounds more universal than "netavark", when it works for any solution like this. Though naming suggestions are welcome, if something sounds better. SuggestionMy private version though for this reason isn't depending on cni-plugins as there's no reason to install it when I use alternative (podman preferred) solution. Should I then remove depency on this PR too, already now? |
How about adding cni-protocol to cni-plugins's dependencies list? This script is tiny and does not take many bytes. |
What a splendid idea! I removed cni-plugins depency from this. |
b984fdf
to
92d9b38
Compare
simple protocol support script for netifd. netifd protocol support for cni networks makes defining network for podman and other similar systems using cni networking much easier and simpler. with cni protocol support, on a cni network, where firewall and portmapper is disabled, you may control firewalling with openwrt's standard firewall configuration. for example, create a container that hosts web content on port 80 with static ip on your cni network, if your network is 10.88.0.0/16, use for eg. 10.88.0.101 as your containers static ip address. Create a zone, cni to your firewall and add your interface to it. Now you can easily set up redirectiong to 10.88.0.101:80 to expose it's port 80 to wan for serving your website. Protocol has only one setting: device, on podman this often is cni-podman0. This protocol may also be used on other equillavents, such as netavark (cni replacement in podman), where device as default is podman0. Signed-off-by: Oskari Rauta <[email protected]>
467e755
to
ec8caa8
Compare
simple protocol support script for netifd.
netifd protocol support for cni networks makes
defining network for podman and other similar
systems using cni networking much easier and simpler.
with cni protocol support, on a cni network, where firewall and portmapper is disabled, you may control firewalling with openwrt's standard firewall configuration.
for example, create a container that hosts web content on port 80 with static ip on your cni network, if your network is 10.88.0.0/16, use for eg. 10.88.0.101 as your containers static ip address. Create a zone, cni to your firewall and add your interface to it. You could manage all this without protocol support, but this makes it a bit easier, especially when this is requirement for my upcoming luci protocol support for same thing- so no tinkering necessary if someone feels more comfortable on LuCi, or just wants to see his interfaces page without warning about unsupported protocol extension.
Now you can easily set up redirectiong to 10.88.0.101:80 to expose it's port 80 to wan for serving your website.
Protocol has only one setting: device, on podman this often is cni-podman0.
Maintainer: me / @oskarirauta
Compile tested: x86_64, recent git
Run tested: x86_64, recent git