Skip to content

[OpenWrt 19.07] python-importlib-metadata: add new package#10443

Merged
BKPepe merged 1 commit into
openwrt:openwrt-19.07from
ja-pa:python-importlib-metadata
Feb 6, 2020
Merged

[OpenWrt 19.07] python-importlib-metadata: add new package#10443
BKPepe merged 1 commit into
openwrt:openwrt-19.07from
ja-pa:python-importlib-metadata

Conversation

@ja-pa
Copy link
Copy Markdown
Contributor

@ja-pa ja-pa commented Nov 3, 2019

Maintainer: me
Compile tested: Turris Omnia (TOS4), OpenWrt master
Run tested: Turris Omnia (TOS4), OpenWrt 19.07

Description:
This PR is based on #8562 . It splits new packages to individuals PR.

Run tested:

>>> from importlib_metadata import version
>>> version('pip')
'19.2.3'

@ja-pa ja-pa marked this pull request as ready for review November 3, 2019 20:57
Copy link
Copy Markdown
Member

@jefferyto jefferyto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this package is only needed for the openwrt-19.07 branch, since master recently updated to Python 3.8. (This package backports a 3.8 module for older versions of Python.)

The install requirements for both pluggy and pytest list this package as necessary only for Python < 3.8.

Comment thread lang/python/python-importlib-metadata/Makefile Outdated
Comment thread lang/python/python-importlib-metadata/Makefile Outdated
@jefferyto
Copy link
Copy Markdown
Member

And this may not be necessary for openwrt-19.07 later, if we update it to Python 3.8 before the branch is frozen.

@BKPepe
Copy link
Copy Markdown
Member

BKPepe commented Jan 19, 2020

@ja-pa ping

Comment thread lang/python/python-importlib-metadata/Makefile Outdated
Comment thread lang/python/python-importlib-metadata/Makefile Outdated
@neheb
Copy link
Copy Markdown
Contributor

neheb commented Jan 25, 2020

Commits should be squashed I think.

@BKPepe
Copy link
Copy Markdown
Member

BKPepe commented Feb 6, 2020

Yes, commits should be squashed to a single one and this PR should be changed just to openwrt-19.07 branch. Also, there is a new version.

Signed-off-by: Jan Pavlinec <jan.pavlinec@nic.cz>
@ja-pa ja-pa changed the base branch from master to openwrt-19.07 February 6, 2020 09:42
@ja-pa ja-pa changed the title python-importlib-metadata: add new package [OpenWrt 19.07] python-importlib-metadata: add new package Feb 6, 2020
@BKPepe
Copy link
Copy Markdown
Member

BKPepe commented Feb 6, 2020

Merging! Thanks for your contribution.

@BKPepe BKPepe merged commit 268ea7a into openwrt:openwrt-19.07 Feb 6, 2020
@jefferyto
Copy link
Copy Markdown
Member

I thought since 19.07 has been released, only bug and security fixes would be merged into the openwrt-19.07 branch, not new packages?

@BKPepe
Copy link
Copy Markdown
Member

BKPepe commented Feb 6, 2020

This was stuck here for a while. This package is not going to be included in OpenWrt master (and OpenWrt 20.xx), because this package is part of Python 3.8. I don't know when 20.xx will be released and if it is decided then it is based on kernel 5.4, then it is going to be delayed.

Should be part of the next OpenWrt 19.xx release and unfortunately, I need to have this package in OpenWrt 19.07, because I updated jsonschema to its the latest version and it was not mention that it added importlib-metadata and it's a pity, but I didn't check setup.cfg for latest changes. :(

On the other hand, I don't need to have patch from this commit, which brings this package or have it included in feed.

@jefferyto
Copy link
Copy Markdown
Member

I can't seem to find a package for jsonschema in the openwrt-19.07 branch?

@BKPepe
Copy link
Copy Markdown
Member

BKPepe commented Feb 6, 2020

Yep, that's correct. It is in Turris OS packages feed for now and I didn't find a time to push it here and it will help me also with Home Assistant, so I dont need to compile it manually each time. I should push those packages here, but hopefully I will do it next month. But jsonschema is part of Docker compose pull request.

@jefferyto
Copy link
Copy Markdown
Member

And all those new packages will go into master, not openwrt-19.07. I still don't see why importlib-metadata needed to be in openwrt-19.07.

@BKPepe
Copy link
Copy Markdown
Member

BKPepe commented Feb 6, 2020

Just personal need. Nothing else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants