lpac: lpac-libmbim-wrapper doesn't work #25035
Comments
fixes openwrt#25035 Signed-off-by: Andrey Butirsky <[email protected]>
|
Wrapping the command is to enable usage with uci. Looking at the project you are referring to, please make https://github.com/stich86/lpac-libmbim-wrapper/blob/main/lpac-mbim#L119C5-L119C8 compatible to supply a |
Still, the path is not required to be the same as the binary, right? Use whatever path for your wrapper, but do not touch the binary path, it's not yours. I think the upstream project behavior is correct, and shouldn't need changes. If I'm missing something, please let me know. |
Where should i put it if not in PATH? Defaulting to configuration is sane behavior for OpenWrt, as this is where the configuration is read from. If what you require is to pass the command-line arguments to the wrapper and override the envrionment it modifies, you can check if the variables are pre-set in the environment and skip the assignment from UCI in the wrapper. |
the PATH is OK, just name it differently, I mean. Nobody will complain.
I do not see why would we want to undertake such complexity if the fix is as simple as rename your wrapper. Anyway, if you want to go that route, would you like to make the fix yourself? |
|
I quite like the wrapper as otherwise you gotta do it all manually which is quite annoying and beats the purpose of having a UCI configuration. |
Some env variables sensitive for proper lpac functioning can be set by upper lpac wrappers such as lpac-libmbim-wrapper. If that's the case, we shouldn't override them, otherwise the wrapper won't work. Also, we shouldn't interpret values of the debug env variables. Instead, we just pass them as is if the corresponding uci optioins exist. fixes openwrt#25035 Signed-off-by: GitHub <[email protected]>
Please see #25046 |
Some env variables sensitive for proper lpac functioning can be set by upper lpac wrappers such as lpac-libmbim-wrapper. If that's the case, we shouldn't override them, otherwise the wrapper won't work. Also, we shouldn't interpret values of the debug env variables. Instead, we just pass them as is if the corresponding uci optioins exist. fixes openwrt#25035 Signed-off-by: Andrey Butirsky <[email protected]>
Maintainer: @blocktrron
Description:
lpac.shwrapper is currently installed by the name of the binary in/usr/bin/lpac:packages/utils/lpac/Makefile
Line 57 in b1635b8
This creates problem as the wrapper overrides env variables which can be set by other upper wrappers.
For now, https://github.com/stich86/lpac-libmbim-wrapper/ doesn't work.
lpac.shmust not mask real binary - instead, it should be installed separately.The text was updated successfully, but these errors were encountered: