Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux-firmware: realtek: add RTL8192FU firmware #17286

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ZerBea
Copy link

@ZerBea ZerBea commented Dec 16, 2024

Added missing firmware: rlt8192fu

updated firmware rlt8192fu

Signed-off-by: Mike <[email protected]>
@github-actions github-actions bot added the core packages pull request/issue for core (in-tree) packages label Dec 16, 2024
@ZerBea
Copy link
Author

ZerBea commented Dec 16, 2024

This pr adds missing support for rtl8192fu.
Issue report is here:
#17284

@ynezz
Copy link
Member

ynezz commented Dec 16, 2024

Thanks for reporting the issue and providing the fix, really appreciated! LGTM, just a small formal remarks:

  1. Can you do git log -p package/firmware/linux-firmware/realtek.mk to see what is expected and adapt your Git commit subject/description accordingly?
  2. Fix the Signed-off-by: by providing the complete real name
  3. Add Fixes: #17284 tag just before the Signed-off-by: line

You can read more about this formal topics in https://openwrt.org/submitting-patches#submission_guidelines

@ynezz ynezz changed the title firmware for rtl8192fu linux-firmware: realtek: add RTL8192FU firmware Dec 16, 2024
@ZerBea
Copy link
Author

ZerBea commented Dec 16, 2024

That was a "quick and dirty PR", done via browser (web interface). Looks like the web interface is not so comfortable as bash.

Commit subject line MUST start with ': ' (Update realtek.mk)
I apologize for the faulty commit subject, I saw this after the submission.

Author name (Mike) need to be your real name 'firstname lastname'
My real first name is Mike and git knows me since 2016: https://github.com/ZerBea. That should be enough.

@ynezz
Copy link
Member

ynezz commented Dec 16, 2024

My real first name is Mike and git knows me since 2016: https://github.com/ZerBea. That should be enough.

openwrt/actions-shared-workflows@12d9551, openwrt/packages#23084

@ZerBea
Copy link
Author

ZerBea commented Dec 16, 2024

Thanks for sharing the link. Interesting discussion.
"Function follows form"

I check the PR. If it is worth it, I merge it and if not, I reject it;
https://github.com/ZerBea/hcxdumptool/pulls?q=is%3Apr+is%3Aclosed
"Form follows function"

@ZerBea
Copy link
Author

ZerBea commented Dec 16, 2024

I code penetration testing tools running on Arch Linux and since Arch Linux dropped support for Raspberry Pi Zero 1
running on OpenWRT.

rtl8xxxu is an impressive driver and a game changer since it joined the bandwagon.
It is worth it to add the firmware for all supported devices:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192f.c?h=v6.6.66
e.g. EDIMAX EW-7722UTn V3

And the same applies to rtw88 usb.

@Neustradamus
Copy link

Interesting PR!

@ZerBea
Copy link
Author

ZerBea commented Dec 20, 2024

@Neustradamus

I'm running Linux kernel: 6.6.65

The device ID 7392:b722 Edimax Technology Co., Ltd 802.11n is small and cheap.

The (new) driver rtl8xxxu is part of the Linux stock kernel.

Th firmware is available on Linux firmware tree.

So why not put it all together:

$ hcxdumptool -L
Requesting physical interface capabilities. This may take some time.
Please be patient...
available wlan devices:

phy idx hw-mac       virtual-mac  m ifname           driver (protocol)
---------------------------------------------------------------------------------------------
  0   3 08beac1c5cac 08beac1c5cac + wlp48s0f4u2u4    rtl8xxxu (NETLINK)

* active monitor mode available (reported by driver - do not trust it)
+ monitor mode available (reported by driver)
- no monitor mode available
$ hcxdumptool -I wlp48s0f4u2u4

Requesting physical interface capabilities. This may take some time.
Please be patient...

interface information:

phy idx hw-mac       virtual-mac  m ifname           driver (protocol)
---------------------------------------------------------------------------------------------
  0   3 08beac1c5cac 08beac1c5cac + wlp48s0f4u2u4    rtl8xxxu (NETLINK)

available frequencies: frequency [channel] tx-power of Regulatory Domain: DE

  2412 [  1] 20.0 dBm	  2417 [  2] 20.0 dBm	  2422 [  3] 20.0 dBm	  2427 [  4] 20.0 dBm
  2432 [  5] 20.0 dBm	  2437 [  6] 20.0 dBm	  2442 [  7] 20.0 dBm	  2447 [  8] 20.0 dBm
  2452 [  9] 20.0 dBm	  2457 [ 10] 20.0 dBm	  2462 [ 11] 20.0 dBm	  2467 [ 12] 20.0 dBm
  2472 [ 13] 20.0 dBm	  2484 [ 14] disabled
$ sudo hcxdumptool -i wlp48s0f4u2u4 --rcascan=active

Requesting physical interface capabilities. This may take some time.
Please be patient...

interface information:

phy idx hw-mac       virtual-mac  m ifname           driver (protocol)
---------------------------------------------------------------------------------------------
  0   3 08beac1c5cac 9c93e46ac07c + wlp48s0f4u2u4    rtl8xxxu (NETLINK)

available frequencies: frequency [channel] tx-power of Regulatory Domain: DE

  2412 [  1] 20.0 dBm	  2417 [  2] 20.0 dBm	  2422 [  3] 20.0 dBm	  2427 [  4] 20.0 dBm
  2432 [  5] 20.0 dBm	  2437 [  6] 20.0 dBm	  2442 [  7] 20.0 dBm	  2447 [  8] 20.0 dBm
  2452 [  9] 20.0 dBm	  2457 [ 10] 20.0 dBm	  2462 [ 11] 20.0 dBm	  2467 [ 12] 20.0 dBm
  2472 [ 13] 20.0 dBm	  2484 [ 14] disabled

scan frequencies: frequency [channel] of Regulatory Domain: DE

  2412 [  1]	  2437 [  6]	  2462 [ 11]

This is a highly experimental penetration testing tool!
It is made to detect vulnerabilities in your NETWORK mercilessly!
Misuse a network, without specific authorization,
may cause irreparable damage and result in significant consequences!
Not understanding what you were doing> is not going to work as an excuse!

BPF is unset! Make sure hcxdumptool is running in a 100% controlled environment!

^C
61 Packet(s) captured by kernel
0 Packet(s) dropped by kernel
18 PROBERESPONSE(s) captured

exit on sigterm

And the bright side: Interface supports a virtual MAC!

For the reviewers:
More information is here:
ZerBea/hcxdumptool#478
and here:
ZerBea/hcxdumptool#361

BTW:
I prefer my own tools for testing purpose because they are doing exactly what I expect.
To reproduce, hcxdumptool is also available via OpenWRT package repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core packages pull request/issue for core (in-tree) packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants