Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: README.md cleanup, content reorganization #691

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

claymcleod
Copy link
Collaborator

@claymcleod claymcleod commented Nov 17, 2024

This pull request cleans up the README.md significantly and with the aim of pushing a decent amount of the content to the website (a future PR is planned for that). The idea is that content should only live in one place—not be duplicated between the README.md and the website—and that the README.md is just the entrypoint to this content (it does not need to cover every detail and historical fact).

I also took the liberty of selecting a font for the README.md header, which is, in some ways, a suggestion for a font for assets from the project as a whole. In this case, I chose Metropolis, which is made available under the UNLICENSE.

Checklist

  • Pull request details were added to CHANGELOG.md
    • No changes were made to the specification, so I considered this to not be relevant.
  • Valid examples WDL's were added or updated to the SPEC.md (see the guide on writing markdown tests)
    • No changes were made to the specification, so I considered this to not be relevant.

@claymcleod claymcleod force-pushed the docs/readme-update branch 2 times, most recently from 894326b to c43ffa1 Compare November 17, 2024 15:27
@claymcleod
Copy link
Collaborator Author

claymcleod commented Nov 17, 2024

I also took a shot at updating some of the colors. I'm not sure if I like that yet. Here are some more options using close to the existing colors.

README Logo-CYAN

README Logo-CYAN Altered

@claymcleod claymcleod marked this pull request as draft November 17, 2024 20:44
@claymcleod claymcleod changed the title [WIP] README.md cleanup, content reorganization README.md cleanup, content reorganization Nov 17, 2024
@claymcleod claymcleod force-pushed the docs/readme-update branch 8 times, most recently from 74dcecc to 33c119b Compare January 11, 2025 20:30
@claymcleod claymcleod marked this pull request as ready for review January 11, 2025 20:33
@claymcleod
Copy link
Collaborator Author

I ended up just using the existing colors as I showed in the examples above. This should now be ready for review.

Copy link
Collaborator

@jdidion jdidion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good - thanks for the revision @claymcleod!

@claymcleod claymcleod force-pushed the docs/readme-update branch 2 times, most recently from 82463a8 to 021ab41 Compare January 14, 2025 01:37
@claymcleod
Copy link
Collaborator Author

@jdidion I think everything has been addressed here.

@claymcleod claymcleod requested a review from jdidion January 14, 2025 01:37
@claymcleod claymcleod self-assigned this Jan 14, 2025
@claymcleod claymcleod added the T-docs (Topic) Documentation changes. label Jan 14, 2025
@claymcleod claymcleod changed the title README.md cleanup, content reorganization docs: README.md cleanup, content reorganization Jan 14, 2025
Copy link
Collaborator

@jdidion jdidion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

This commit is the squashed product of the following commits:

* docs: adds `README.md` header image
* docs: updates `README.md` with new information, deduplicates content
* revise: add @jdidion's suggestions
* revise: one sentence per line

Co-authored-by: John Didion <[email protected]>
@claymcleod
Copy link
Collaborator Author

Note that I plan to make further changes to the fonts, etc, in the future. For now, I'll merge this in as it's a big improvement.

@claymcleod claymcleod merged commit f90e4ae into openwdl:wdl-1.2 Jan 23, 2025
@claymcleod claymcleod deleted the docs/readme-update branch January 23, 2025 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-docs (Topic) Documentation changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants