Uniffi android controller #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swaptr
force-pushed
the
uniffi-android-controller
branch
from
339f7ec to
f890b30
Compare
Codecov Report
@@ Coverage Diff @@
## main #984 +/- ##
=======================================
Coverage 30.01% 30.01%
=======================================
Files 415 415
Lines 26916 26916
Branches 5243 5243
=======================================
Hits 8080 8080
Misses 16639 16639
Partials 2197 2197
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Nice, let me know once this has been rebased and ready to review 👌. Also, please make sure that the CI lint checks are satisfied |
swaptr
force-pushed
the
uniffi-android-controller
branch
5 times, most recently
from
8bb518a to
56baf4a
Compare
gmulhearn
approved these changes
Sep 25, 2023
gmulhearn
requested changes
Sep 25, 2023
Signed-off-by: Swapnil Tripathi <[email protected]>
swaptr
force-pushed
the
uniffi-android-controller
branch
from
56baf4a to
620733f
Compare
gmulhearn-anonyome
approved these changes
Sep 25, 2023
gmulhearn
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credits to @gmulhearn for simplifying the android code by adding a controller. 🚀
Merge after #970