Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uniffi demo qr scan #954

Merged
merged 13 commits into from
Sep 7, 2023
Merged

Uniffi demo qr scan #954

merged 13 commits into from
Sep 7, 2023

Conversation

swaptr
Copy link
Contributor

@swaptr swaptr commented Aug 24, 2023

Merge only after #896
This PR elaborates the Uniffi demo and API.

@swaptr swaptr requested a review from gmulhearn August 24, 2023 06:05
@swaptr swaptr self-assigned this Aug 24, 2023
@swaptr swaptr force-pushed the uniffi-demo-qr-scan branch 2 times, most recently from 6de427b to 315c779 Compare August 24, 2023 06:29
@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2023 •
edited
Loading

Codecov Report

Merging #954 (7ef73e8) into main (1c79a86) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #954   +/-   ##
=======================================
  Coverage   39.32%   39.32%           
=======================================
  Files         414      414           
  Lines       28863    28863           
  Branches     6183     6183           
=======================================
  Hits        11349    11349           
- Misses      14174    14175    +1     
+ Partials     3340     3339    -1
Flag Coverage Δ
unittests-aries-vcx 39.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@swaptr swaptr force-pushed the uniffi-demo-qr-scan branch 2 times, most recently from 24288f7 to 95be760 Compare August 29, 2023 07:28
@swaptr
Copy link
Contributor Author

swaptr commented Aug 29, 2023

On generating a new indy profile, the application terminates.
Logcat:

2023-08-29 13:18:04.298 14352-14418 AndroidRuntime          org.hyperledger.ariesvcx             E  FATAL EXCEPTION: DefaultDispatcher-worker-1
                                                                                                    Process: org.hyperledger.ariesvcx, PID: 14352
                                                                                                    org.hyperledger.ariesvcx.VcxUniFfiException$SerializationException: A serialization error occurred. Check your inputs. More Info: EOF while parsing a value at line 1 column 0
                                                                                                    	at org.hyperledger.ariesvcx.FfiConverterTypeVcxUniFfiError.read(vcx.kt:915)
                                                                                                    	at org.hyperledger.ariesvcx.FfiConverterTypeVcxUniFfiError.read(vcx.kt:910)
                                                                                                    	at org.hyperledger.ariesvcx.FfiConverter$DefaultImpls.liftFromRustBuffer(vcx.kt:151)
                                                                                                    	at org.hyperledger.ariesvcx.FfiConverterRustBuffer$DefaultImpls.liftFromRustBuffer(vcx.kt:163)
                                                                                                    	at org.hyperledger.ariesvcx.FfiConverterTypeVcxUniFfiError.liftFromRustBuffer(vcx.kt:910)
                                                                                                    	at org.hyperledger.ariesvcx.FfiConverterTypeVcxUniFfiError.liftFromRustBuffer(vcx.kt:910)
                                                                                                    	at org.hyperledger.ariesvcx.FfiConverterRustBuffer$DefaultImpls.lift(vcx.kt:164)
                                                                                                    	at org.hyperledger.ariesvcx.FfiConverterTypeVcxUniFfiError.lift(vcx.kt:910)
                                                                                                    	at org.hyperledger.ariesvcx.FfiConverterTypeVcxUniFfiError.lift(vcx.kt:910)
                                                                                                    	at org.hyperledger.ariesvcx.VcxUniFfiException$ErrorHandler.lift(vcx.kt:906)
                                                                                                    	at org.hyperledger.ariesvcx.VcxUniFfiException$ErrorHandler.lift(vcx.kt:905)
                                                                                                    	at org.hyperledger.ariesvcx.VcxKt.createInvitee(vcx.kt:1087)
                                                                                                    	at org.hyperledger.ariesvcx.MainActivity.setProfileHolder(MainActivity.kt:29)
                                                                                                    	at org.hyperledger.ariesvcx.MainActivity.access$setProfileHolder(MainActivity.kt:23)
                                                                                                    	at org.hyperledger.ariesvcx.MainActivity$onCreate$1$1$1$1.invoke(MainActivity.kt:41)
                                                                                                    	at org.hyperledger.ariesvcx.MainActivity$onCreate$1$1$1$1.invoke(MainActivity.kt:41)
                                                                                                    	at org.hyperledger.ariesvcx.HomeScreenKt$HomeScreen$1$1$1.invokeSuspend(HomeScreen.kt:47)
                                                                                                    	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
                                                                                                    	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
                                                                                                    	at kotlinx.coroutines.internal.LimitedDispatcher.run(LimitedDispatcher.kt:42)
                                                                                                    	at kotlinx.coroutines.scheduling.TaskImpl.run(Tasks.kt:95)
                                                                                                    	at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:570)
                                                                                                    	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:750)
                                                                                                    	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:677)
                                                                                                    	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:664)
                                                                                                    	Suppressed: kotlinx.coroutines.DiagnosticCoroutineContextException: [androidx.compose.ui.platform.MotionDurationScaleImpl@7db2491, androidx.compose.runtime.BroadcastFrameClock@698eff6, StandaloneCoroutine{Cancelling}@67f4ff7, Dispatchers.IO]
2023-08-29 13:18:04.311 14352-14418 Process                 org.hyperledger.ariesvcx             I  Sending signal. PID: 14352 SIG: 9

@swaptr swaptr force-pushed the uniffi-demo-qr-scan branch 4 times, most recently from 5eb93e4 to 2db7884 Compare September 1, 2023 12:13
gmulhearn
gmulhearn requested changes Sep 2, 2023
View reviewed changes
Copy link
Contributor

@gmulhearn gmulhearn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, it's looking good. just some smallish comments, let me know when they're resolved or if any questions

@swaptr swaptr force-pushed the uniffi-demo-qr-scan branch 4 times, most recently from 20e52b9 to 197cbf8 Compare September 3, 2023 12:38
@swaptr swaptr marked this pull request as ready for review September 5, 2023 05:08
@swaptr
add nav and qr code scanning
1cf0f2f 
Signed-off-by: Swapnil Tripathi <[email protected]>
swaptr added 12 commits September 5, 2023 10:39
@swaptr
decode url
90f25b3 
Signed-off-by: Swapnil Tripathi <[email protected]>
@swaptr
create new indy profile demo
a6a6fbd 
Signed-off-by: Swapnil Tripathi <[email protected]>
@swaptr
fix demo app qr scan
9448c53 
Signed-off-by: Swapnil Tripathi <[email protected]>
@swaptr
fix definitions for Connection and ProfileHolder
8545eec 
Signed-off-by: Swapnil Tripathi <[email protected]>
@swaptr
fix serialization
fcf6fbe 
Signed-off-by: Swapnil Tripathi <[email protected]>
@swaptr
update gradle plugin
62f4ef8 
Signed-off-by: Swapnil Tripathi <[email protected]>
@swaptr
fix navigation bug and implement sendRequest
ba34294 
Signed-off-by: Swapnil Tripathi <[email protected]>
@swaptr
cleanup
e5b359d 
Signed-off-by: Swapnil Tripathi <[email protected]>
@swaptr
apply changes from review
f9a86cf 
Signed-off-by: Swapnil Tripathi <[email protected]>
@swaptr
fix state variable for active connection and profileHolder
d3962e4 
Signed-off-by: Swapnil Tripathi <[email protected]>
@swaptr
fix network permissions
be171ef 
Signed-off-by: Swapnil Tripathi <[email protected]>
@swaptr
uniffi demo cleanup
7ef73e8 
Signed-off-by: Swapnil Tripathi <[email protected]>
@swaptr swaptr force-pushed the uniffi-demo-qr-scan branch from db735bd to 7ef73e8 Compare September 5, 2023 05:09
@swaptr swaptr mentioned this pull request Sep 6, 2023
Merged
@gmulhearn gmulhearn merged commit c08650a into openwallet-foundation:main Sep 7, 2023
bobozaur pushed a commit that referenced this pull request Sep 14, 2023
@swaptr @bobozaur
Uniffi demo qr scan (#954)
1f3ea6a 
* add nav and qr code scanning

Signed-off-by: Swapnil Tripathi <[email protected]>

* decode url

Signed-off-by: Swapnil Tripathi <[email protected]>

* create new indy profile demo

Signed-off-by: Swapnil Tripathi <[email protected]>

* fix demo app qr scan

Signed-off-by: Swapnil Tripathi <[email protected]>

* fix definitions for Connection and ProfileHolder

Signed-off-by: Swapnil Tripathi <[email protected]>

* fix serialization

Signed-off-by: Swapnil Tripathi <[email protected]>

* update gradle plugin

Signed-off-by: Swapnil Tripathi <[email protected]>

* fix navigation bug and implement sendRequest

Signed-off-by: Swapnil Tripathi <[email protected]>

* cleanup

Signed-off-by: Swapnil Tripathi <[email protected]>

* apply changes from review

Signed-off-by: Swapnil Tripathi <[email protected]>

* fix state variable for active connection and profileHolder

Signed-off-by: Swapnil Tripathi <[email protected]>

* fix network permissions

Signed-off-by: Swapnil Tripathi <[email protected]>

* uniffi demo cleanup

Signed-off-by: Swapnil Tripathi <[email protected]>

---------

Signed-off-by: Swapnil Tripathi <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Patrik-Stas Patrik-Stas Patrik-Stas left review comments

@gmulhearn gmulhearn gmulhearn approved these changes

Assignees

@swaptr swaptr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@swaptr @codecov-commenter @Patrik-Stas @gmulhearn