Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read the environment var TRUST_ENV and pass it on to aiohttp.ClientSe… #980

Closed

Conversation

vitalrev
Copy link
Contributor

The issue is described here: #977

it's my first PR in AcaPy... I hope I did not forget anything

@vitalrev vitalrev marked this pull request as ready for review February 18, 2021 19:49
@andrewwhitehead
Copy link
Contributor

Thanks for the PR! The ACA-Py agent already looks for several environment variables at startup as part of its configuration, so I'm inclined to just set trust_env=True all of the time. There are also places where we use the requests library instead, but it appears to use the same environment variables by default.

@vitalrev vitalrev marked this pull request as draft February 19, 2021 01:17
@vitalrev
Copy link
Contributor Author

Thanks for the quick response! If you implement/set the trust_env=True for ClientSession(trust_env=True), it's fine for me... than we can close this PR :)

@vitalrev
Copy link
Contributor Author

an another problem with proxy is the bug in aiohttp: aio-libs/aiohttp#4445
I tested with patched aiohttp and patched AcaPy 0.5.6 version...

@andrewwhitehead
Copy link
Contributor

Thanks, hopefully aiohttp adds that fix into a release soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants