Singlebranch #5251
Closed
Singlebranch #5251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magnumripper
force-pushed
the
singlebranch
branch
from
142e8a0 to
007ae0a
Compare
Closed
That was a commit mistake. Performance is up a good deal now, 19144M seen. Lowering from 125 to 59 doesn't make any difference. |
magnumripper
force-pushed
the
singlebranch
branch
7 times, most recently
from
2cac6d5 to
7b132a4
Compare
Found when implementing a 64-bit version of it. The impact would be suboptimal bitmap parameters when adjusting bitmap as the number of remaining hashes decreases.
Not only do we save memory, we can reverse much more as well! We check the remaining bits in cold host code, for good measure.
This way we still got optimal speed for the original nt-opencl format that support lengths up to 27. 1 block of MD4 is up to 27 characters. 2 blocks is 59, 3 is 91, 4 is 123 and 5 is 125 (due to core max). As long as we bump it over 27 we don't seem to gain any speed by limiting it to less than 125 characters. See openwall#5245
magnumripper
force-pushed
the
singlebranch
branch
from
7b132a4 to
adc6ec6
Compare
Now just a single branch in end of function.
magnumripper
force-pushed
the
singlebranch
branch
from
adc6ec6 to
fd2fa4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Third try.
Now there's just a single
if unlikely()in the end of the function,but AMD still acts up with poor performance😢