Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of global hparams #240

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

hrukalive
Copy link

This is an attempt to remove all dependencies on the global hparams. Now, hyperparameters are passed in as an argument called config, following the approaches in SOME and SOFA. Other than find-and-replace in modules, the bigger changes are in scripts/*.py.

PS: Not fully tested yet

@hrukalive hrukalive marked this pull request as draft March 30, 2025 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant