Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add submodule: nlohmann json (Release 3.10.4) #8915

Merged
merged 3 commits into from
Dec 2, 2021
Merged

Add submodule: nlohmann json (Release 3.10.4) #8915

merged 3 commits into from
Dec 2, 2021

Conversation

itikhono
Copy link
Contributor

@itikhono itikhono commented Nov 30, 2021 •
edited
Loading

Details:

Tickets:

  • 68214
  • 72746

@itikhono itikhono requested review from ilya-lavrenov, asomsiko and a team November 30, 2021 08:38
@itikhono itikhono added this to the 2022.1 milestone Nov 30, 2021
@openvino-pushbot openvino-pushbot added the category: inference OpenVINO Runtime library - Inference label Nov 30, 2021
ilyachur
ilyachur reviewed Nov 30, 2021
View reviewed changes
.gitmodules
@@ -59,3 +59,6 @@
[submodule "tools/pot/thirdparty/open_model_zoo"]
path = tools/pot/thirdparty/open_model_zoo
url = https://github.com/openvinotoolkit/open_model_zoo.git
[submodule "thirdparty/nlohmann_json"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ttroilov FYI we are adding new dependency

@itikhono itikhono requested a review from ttroilov November 30, 2021 10:57
@ilyachur ilyachur merged commit e23e6f3 into openvinotoolkit:master Dec 2, 2021
@itikhono
Copy link
Contributor Author

itikhono commented Dec 2, 2021

CI passed and we decided to merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttroilov ttroilov ttroilov approved these changes

@ilyachur ilyachur ilyachur approved these changes

@ilya-lavrenov ilya-lavrenov ilya-lavrenov approved these changes

@asomsiko asomsiko Awaiting requested review from asomsiko

Assignees
No one assigned
Labels
category: inference OpenVINO Runtime library - Inference
Projects
None yet
Milestone
2022.1
Development

Successfully merging this pull request may close these issues.
5 participants
@itikhono @ilya-lavrenov @ilyachur @ttroilov @openvino-pushbot