Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GPU] Rollback to cldnn from onednn and some fixes and improvements #8761

Merged
merged 3 commits into from
Dec 2, 2021
Merged

[GPU] Rollback to cldnn from onednn and some fixes and improvements #8761

merged 3 commits into from
Dec 2, 2021

Conversation

lznamens
Copy link
Contributor

Details:

  • Rollback to cldnn for cases with extremely low onednn usage ratio
  • Concatenation ref kernel fix (double blocked format added)
  • Layout optimizer fix for double blocked >4d-dims formats
  • Fixed eltwise as onednn sum post_operation in the "product" mode
  • Some graph-side improvements

Tickets:

  • ticket-id

@lznamens lznamens added the category: GPU OpenVINO GPU plugin label Nov 23, 2021
@lznamens lznamens added this to the 2022.1 milestone Nov 23, 2021
@lznamens lznamens requested review from a team as code owners November 23, 2021 09:47
@lznamens lznamens force-pushed the feature/iznamenskiy/onednn_way_optimizations branch from 8a08196 to db17463 Compare November 29, 2021 09:51
sshlyapn
sshlyapn approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@sshlyapn sshlyapn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lznamens
[GPU] Rollback to cldnn from onednn and some fixes and improvements
8e1a169 
[GPU] Onednn graph optimizations and cldnn rollback in some cases

[GPU] Added floating point support for b_fs_yx_fsv32

[GPU] Rollback to cldnn inside reorder_inputs pass

[GPU] Debug commit for paddings merging

[GPU] Do not add paddings for OneDNN primitives

[GPU] Some fsv32 optimizations

Revert "[GPU] Do not add paddings for OneDNN primitives"

This reverts commit bd2d32316aad5577f341bc4042e1a5d29eb45769.

[GPU] Some code fixes

[GPU] Todo corrections

[GPU] Added double blocked formats bsv fsv into concatenation ref

[GPU] Double blocked formats correction and small fixes
@lznamens
[GPU] The code review fixes
e04f2cb
@lznamens lznamens force-pushed the feature/iznamenskiy/onednn_way_optimizations branch from db17463 to 0cbea5d Compare December 1, 2021 06:00
@lznamens lznamens requested review from isanghao and sshlyapn December 1, 2021 06:03
isanghao
isanghao approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@isanghao isanghao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lznamens lznamens force-pushed the feature/iznamenskiy/onednn_way_optimizations branch from 0cbea5d to 92d27fc Compare December 1, 2021 09:39
@vladimir-paramuzov vladimir-paramuzov merged commit 6078148 into openvinotoolkit:master Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isanghao isanghao isanghao approved these changes

@sshlyapn sshlyapn Awaiting requested review from sshlyapn

Assignees
No one assigned
Labels
category: GPU OpenVINO GPU plugin
Projects
None yet
Milestone
2022.1
Development

Successfully merging this pull request may close these issues.
4 participants
@lznamens @sshlyapn @isanghao @vladimir-paramuzov