Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python API for If operation #7934

Merged
merged 56 commits into from
Dec 1, 2021
Merged

Python API for If operation #7934

merged 56 commits into from
Dec 1, 2021

Conversation

evolosen
Copy link
Contributor

@evolosen evolosen commented Oct 11, 2021 •
edited
Loading

Ticket: #50059
Python API for If operation

evolosen added 13 commits December 3, 2020 11:44
@evolosen
Merge pull request #1 from openvinotoolkit/master
56b755e 
update my fork
@evolosen
Merge pull request #2 from openvinotoolkit/master
fbfe44c 
Update forked branch
@evolosen
Merge pull request #3 from openvinotoolkit/master
0cf84d4 
Update forked branch
@evolosen
Merge pull request #4 from openvinotoolkit/master
0df8350 
Update forked branch
@evolosen
Merge pull request #5 from openvinotoolkit/master
c299e1d 
Update forked branch
@evolosen
Merge pull request #6 from openvinotoolkit/master
f4f54ac 
Update forked branch
@evolosen
Update forked branch
8feeba4 
Update forked branch
@evolosen
Merge pull request #8 from openvinotoolkit/master
fb93329 
Update forked branch
@evolosen
Merge pull request #9 from openvinotoolkit/master
2a19318 
Update forked branch
@evolosen
Update forked branch
c09041d 
Update forked branch
@evolosen
Merge remote-tracking branch 'upstream/master'
c122d92
@evolosen
Merge remote-tracking branch 'upstream/master'
ef33e30
@evolosen
add if in python_api
fca6e5a
@evolosen evolosen requested a review from a team October 11, 2021 08:20
@openvino-pushbot openvino-pushbot added the category: inference OpenVINO Runtime library - Inference label Oct 11, 2021
@evolosen evolosen closed this Oct 11, 2021
@evolosen evolosen reopened this Oct 11, 2021
@evolosen evolosen changed the title Ngraph/python api Python API for If operation Oct 11, 2021
@jiwaszki jiwaszki self-requested a review October 12, 2021 09:24
jiwaszki
jiwaszki suggested changes Oct 12, 2021
View reviewed changes
Copy link

@jiwaszki jiwaszki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should wait for #7658 to be merged first. After that change .../compatibility/... path to new directory with ops.

runtime/bindings/python/src/compatibility/ngraph/opset8/ops.py Outdated Show resolved Hide resolved
runtime/bindings/python/src/compatibility/ngraph/opset8/ops.py Outdated Show resolved Hide resolved
runtime/bindings/python/src/compatibility/ngraph/opset8/ops.py Outdated Show resolved Hide resolved
@evolosen evolosen requested review from itikhono, a team, pavel-esir, mvafin and popovaan and removed request for a team, mvafin and popovaan October 13, 2021 09:51
@jiwaszki
Copy link

@evolosen Please add op to compatibility's opset8 and compatibility tests as well, because of the misunderstanding in plans for OV2.0 Python API.

CC @tomdol @ilyachur

@rkazants rkazants requested a review from akuporos November 17, 2021 10:48
@rkazants
Copy link
Member

@akuporos, could you please review this one?

jiwaszki
jiwaszki suggested changes Nov 19, 2021
View reviewed changes
Copy link

@jiwaszki jiwaszki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also tests are required in openvino/runtime/bindings/python/tests_compatibility/test_ngraph

runtime/bindings/python/src/compatibility/ngraph/opset8/ops.py Outdated Show resolved Hide resolved
runtime/bindings/python/src/openvino/opset8/ops.py Outdated Show resolved Hide resolved
runtime/bindings/python/tests/test_ngraph/test_node_factory.py Outdated Show resolved Hide resolved
runtime/bindings/python/tests/test_ngraph/test_reduction.py Outdated Show resolved Hide resolved
@evolosen evolosen requested a review from jiwaszki November 22, 2021 09:37
@andrei-kochin andrei-kochin merged commit 81b003e into openvinotoolkit:master Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiwaszki jiwaszki jiwaszki approved these changes

@sadolini sadolini sadolini approved these changes

@itikhono itikhono itikhono approved these changes

@pavel-esir pavel-esir Awaiting requested review from pavel-esir pavel-esir was automatically assigned from openvinotoolkit/openvino-mo-developers

@yekruglov yekruglov Awaiting requested review from yekruglov yekruglov was automatically assigned from openvinotoolkit/openvino-mo-developers

@akuporos akuporos Awaiting requested review from akuporos

Assignees
No one assigned
Labels
category: inference OpenVINO Runtime library - Inference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@evolosen @jiwaszki @rkazants @itikhono @sadolini @openvino-pushbot @andrei-kochin