[GNA] More precized calculation of Log pwl and pwl with sf < 1 #7884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elilobanova
requested review from
nkogteva,
mryzhov,
dmitriikhurtin and
a team
openvino-pushbot
added
category: GNA
dmitriikhurtin
approved these changes
Oct 7, 2021
|
I'm wondering whether this PR can help to enable any disabled activation tests or not? |
nkogteva
reviewed
Oct 7, 2021
inference-engine/tests/functional/plugin/gna/scale_factors_tests/test_fq_scale_factors.cpp
Show resolved
Hide resolved
this PR doesn't enable activation tests, I think these tests rather depends on number of segments for PWL, probably we need to use configuration option PWL_ME or change the plugin behavior to chose the biggest possible number of segments without this option, |
nkogteva
approved these changes
Oct 12, 2021
elilobanova
force-pushed
the
slope_small_sf
branch
from
e983eb1 to
2bc8326
Compare
elilobanova
force-pushed
the
slope_small_sf
branch
from
2bc8326 to
56df65f
Compare
elilobanova
added a commit
to elilobanova/openvino
that referenced
this pull request
Oct 13, 2021
…inotoolkit#7884) * [GNA] More precized calculation of Log pwl and pwl with sf < 1 * [GNA] Added tests * [GNA] Types correction * [GNA] Added comment for absolute threshold calculation in the test
azhogov
pushed a commit
that referenced
this pull request
Oct 14, 2021
#7982) * [GNA] More precized calculation of Log pwl and pwl with sf < 1 * [GNA] Added tests * [GNA] Types correction * [GNA] Added comment for absolute threshold calculation in the test
tadamowicz
pushed a commit
to tadamowicz/openvino
that referenced
this pull request
Aug 30, 2023
…inotoolkit#7884) * [GNA] More precized calculation of Log pwl and pwl with sf < 1 * [GNA] Added tests * [GNA] Types correction * [GNA] Added comment for absolute threshold calculation in the test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets:
67349