Skip to content

[XXX-55386] Change nets version to v10 #7289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 7, 2021
Merged

[XXX-55386] Change nets version to v10 #7289

merged 10 commits into from
Sep 7, 2021

Conversation

monroid
Copy link
Contributor

@monroid monroid commented Aug 30, 2021

Details:

  • inference-engine\tests\functional\inference_engine\local_test.cpp

Tickets:

  • [XXX-55386]

@monroid monroid requested review from a team, vurusovs and dmaksimo August 30, 2021 12:12
@openvino-pushbot openvino-pushbot added the category: IE Tests OpenVINO Test: plugins and common label Aug 30, 2021
@dmaksimo
Copy link

@monroid , let's use code review document with the relevant articles. Please add that to the description|:

https://wiki.ith.intel.com/display/CVSDK/Model+Optimizer+Code+Review+Template

@monroid
Copy link
Contributor Author

monroid commented Aug 30, 2021

@dmaksimo as I see, different teams use dedicated templates. My change relates to tests, so MO rules are really complicated for this one, IMHO.

@dmaksimo
Copy link

@dmaksimo as I see, different teams use dedicated templates. My change relates to tests, so MO rules are really complicated for this one, IMHO.

But can you add a description, RCA and Solution test, so the reader can understand the changes?

@iefode iefode changed the title [CVS-55386] Change nets version to v10 [XXX-55386] Change nets version to v10 Aug 31, 2021
@ilya-lavrenov ilya-lavrenov added this to the 2022.1 milestone Sep 3, 2021
@ilya-lavrenov ilya-lavrenov enabled auto-merge (squash) September 3, 2021 08:45
Copy link
Contributor

@vurusovs vurusovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ilya-lavrenov ilya-lavrenov merged commit f890b12 into openvinotoolkit:master Sep 7, 2021
@monroid
Copy link
Contributor Author

monroid commented Sep 7, 2021

@ilya-lavrenov @iefode @vurusovs Thanks, folks!

akuporos pushed a commit to akuporos/openvino that referenced this pull request Sep 29, 2021
* CVS-56144 Enable all OMZ scope

* [CVS-55368] Change nets version to v10

* [CVS-55386] Fix some coments

* [CVS-55386] Added float param to LSTM net

* Updated nets

* [CVS-55386] Change to ngraph way
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: IE Tests OpenVINO Test: plugins and common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants